Re: [PATCH 23/45] KVM: Introduce kvm_check_gen()/kvm_memslots_check_gen()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] KVM: loongarch: missing closing parenthesis in steal time if conditions
--

commit 12eefe95ee8b4f21b2235f3a2ed98ccc73873acc
Author: Paolo Bonzini <pbonzini@redhat.com>

KVM: Introduce kvm_check_gen()/kvm_memslots_check_gen()

This commit introduces the kvm_check_gen() and kvm_memslots_check_gen()
helper functions to check the memslot generation and optionally return the
kvm_memslots pointer, converting several callers across KVM to use them.

Link: https://patch.msgid.link/20260918135030.171564-21-pbonzini@redhat.com

> diff --git a/arch/loongarch/kvm/vcpu.c b/arch/loongarch/kvm/vcpu.c
> index 059a6d605de77..c3e71ef983bcb 100644
> --- a/arch/loongarch/kvm/vcpu.c
> +++ b/arch/loongarch/kvm/vcpu.c
> @@ -154,7 +154,6 @@ static void kvm_update_stolen_time(struct kvm_vcpu *vcpu)
>  	u32 version;
>  	u64 steal;
>  	gpa_t gpa;
> -	struct kvm_memslots *slots;
>  	struct kvm_steal_time __user *st;
>  	struct gfn_to_hva_cache *ghc;
>  
> @@ -164,9 +163,8 @@ static void kvm_update_stolen_time(struct kvm_vcpu *vcpu)
>  		return;
>  
>  	gpa &= KVM_STEAL_PHYS_MASK;
> -	slots = kvm_memslots(vcpu->kvm);
> -	if (unlikely(slots->generation != ghc->generation || gpa != ghc->gpa ||
> -		     kvm_is_error_hva(ghc->hva) || !ghc->memslot)) {
> +	if (unlikely(!kvm_check_gen(vcpu->kvm, ghc->generation) || gpa != ghc->gpa ||
> +		     kvm_is_error_hva(ghc->hva) || !ghc->memslot) {
>  		if (kvm_gfn_to_hva_cache_init(vcpu->kvm, ghc, gpa, sizeof(*st))) {
>  			ghc->gpa = INVALID_GPA;
>  			return;
> @@ -1803,7 +1801,6 @@ static void kvm_vcpu_set_pv_preempted(struct kvm_vcpu *vcpu)
>  {
>  	gpa_t gpa;
>  	struct gfn_to_hva_cache *ghc;
> -	struct kvm_memslots *slots;
>  	struct kvm_steal_time __user *st;
>  
>  	gpa = vcpu->arch.st.guest_addr;
> @@ -1820,9 +1817,8 @@ static void kvm_vcpu_set_pv_preempted(struct kvm_vcpu *vcpu)
>  
>  	gpa &= KVM_STEAL_PHYS_MASK;
>  	ghc = &vcpu->arch.st.cache;
> -	slots = kvm_memslots(vcpu->kvm);
> -	if (unlikely(slots->generation != ghc->generation || gpa != ghc->gpa ||
> -		     kvm_is_error_hva(ghc->hva) || !ghc->memslot)) {
> +	if (unlikely(!kvm_check_gen(vcpu->kvm, ghc->generation) || gpa != ghc->gpa ||
> +		     kvm_is_error_hva(ghc->hva) || !ghc->memslot) {
>  		if (kvm_gfn_to_hva_cache_init(vcpu->kvm, ghc, gpa, sizeof(*st))) {
>  			ghc->gpa = INVALID_GPA;
>  			return;

[Severity: Low]
In both kvm_update_stolen_time() and kvm_vcpu_set_pv_preempted() in
arch/loongarch/kvm/vcpu.c, replacing the generation check dropped one of
the closing parentheses at the end of !ghc->memslot)) {, leaving the outer
if condition unclosed and breaking the LoongArch KVM build.

Note that a later commit in the series (c500cbe0be12) updates the arguments
to kvm_check_gen() at both sites without restoring the missing closing
parenthesis.

Should both conditions end with !ghc->memslot)) { instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102174130.8779-1-pbonzini@redhat.com?part=23