Re: [PATCH 6/7] ASoC: Intel: avs: Expose common PCM functions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ASoC: Intel: avs: duplicate header includes in pcm.h
--

commit 9d263961a528ee317534dc04cdc45b51e6460ff0
Author: Cezary Rojewski <cezary.rojewski@intel.com>

ASoC: Intel: avs: Expose common PCM functions

This commit moves struct avs_dma_data and declarations for common DAI and
component registration functions into sound/soc/intel/avs/pcm.h so that PCM
operations can be split across multiple files.

> diff --git a/sound/soc/intel/avs/pcm.h b/sound/soc/intel/avs/pcm.h
> index 0f3615c903982..ac127ade4ca1c 100644
> --- a/sound/soc/intel/avs/pcm.h
> +++ b/sound/soc/intel/avs/pcm.h
> @@ -9,8 +9,57 @@
>  #ifndef __SOUND_SOC_INTEL_AVS_PCM_H
>  #define __SOUND_SOC_INTEL_AVS_PCM_H
>  
> +#include <linux/device.h>
> +#include <sound/hdaudio_ext.h>
>  #include <sound/pcm.h>
> +#include <sound/pcm_params.h>
> +#include <sound/soc-acpi.h>
> +#include <sound/pcm_params.h>
> +#include <sound/soc-acpi.h>

[Severity: Low]
This isn't a bug, but in sound/soc/intel/avs/pcm.h under
__SOUND_SOC_INTEL_AVS_PCM_H, sound/pcm_params.h and sound/soc-acpi.h are
included twice in a row. Could the duplicate #include directives be
removed?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102181042.1922005-1-cezary.rojewski@intel.com?part=6