Re: [PATCH 2/7] soundwire: intel: Allow for dynamic assignment of PDIs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] soundwire: cadence: missing kernel-doc for sdw_cdns_release_pdi() and pdi_lock
--

commit 7d3c13df44bfa3764481f78c64186b31510a9ae2
Author: Cezary Rojewski <cezary.rojewski@intel.com>

soundwire: intel: Allow for dynamic assignment of PDIs

This commit adds sdw_cdns_assign_pdi() and sdw_cdns_release_pdi() to allow
dynamic assignment and release of Cadence PDIs, along with
sdw_intel_pdi_config() to separate PDI assignment during startup from
hardware configuration during hw_params.

> diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
> index a0a63b76793e2..9375db9c08a2d 100644
> --- a/drivers/soundwire/cadence_master.c
> +++ b/drivers/soundwire/cadence_master.c
[ ... ]
> @@ -1991,6 +1993,68 @@ struct sdw_cdns_pdi *sdw_cdns_alloc_pdi(struct sdw_cdns *cdns,
[ ... ]
> +/**
> + * sdw_cdns_release_pdi() - Release a PDI
> + * @pdi: PDI instance
> + */
> +void sdw_cdns_release_pdi(struct sdw_bus *bus, struct sdw_cdns_pdi *pdi)
> +{
> +	struct sdw_cdns *cdns = bus_to_cdns(bus);
> +
> +	guard(spinlock)(&cdns->pdi_lock);
> +	pdi->assigned = false;
> +}
> +EXPORT_SYMBOL(sdw_cdns_release_pdi);
[ ... ]
> diff --git a/drivers/soundwire/cadence_master.h b/drivers/soundwire/cadence_master.h
> index f4e41a9ab1658..f52c9cbec8a91 100644
> --- a/drivers/soundwire/cadence_master.h
> +++ b/drivers/soundwire/cadence_master.h
[ ... ]
> @@ -140,6 +121,7 @@ struct sdw_cdns {
>  	int num_ports;
>  
>  	struct sdw_cdns_streams pcm;
> +	spinlock_t pdi_lock;

[Severity: Low]
Should the kernel-doc comments be updated for these additions to avoid W=1
build warnings? Specifically, sdw_cdns_release_pdi() in
drivers/soundwire/cadence_master.c omits the @bus parameter from its
kernel-doc header, and struct sdw_cdns in drivers/soundwire/cadence_master.h
is missing a kernel-doc entry for @pdi_lock.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102181042.1922005-1-cezary.rojewski@intel.com?part=2