* [PATCH 1/1] PCI: epf-mhi: use dmaengine_desc_set_callback()
@ 2026-11-02 19:55 Frank.Li
2026-11-02 20:00 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Frank.Li @ 2026-11-02 19:55 UTC (permalink / raw)
To: Manivannan Sadhasivam, Jeff Hugo, Krzysztof Wilczyński,
Kishon Vijay Abraham I, Frank Li, Bjorn Helgaas,
open list:MHI BUS, open list:MHI BUS,
open list:PCI ENDPOINT SUBSYSTEM, open list
Cc: imx, vkoul, Frank Li
From: Frank Li <Frank.Li@nxp.com>
Replace open-coded assignments to callback and callback_param fields of
struct dma_async_tx_descriptor with calls to the
dmaengine_desc_set_callback() helper.
No functional change intended. Prepare to make struct
dma_async_tx_descriptor private to the DMA engine.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/pci/endpoint/functions/pci-epf-mhi.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/pci/endpoint/functions/pci-epf-mhi.c b/drivers/pci/endpoint/functions/pci-epf-mhi.c
index 78f1fb1a6b0c7..a63c50d235d6e 100644
--- a/drivers/pci/endpoint/functions/pci-epf-mhi.c
+++ b/drivers/pci/endpoint/functions/pci-epf-mhi.c
@@ -346,8 +346,8 @@ static int pci_epf_mhi_edma_read(struct mhi_ep_cntrl *mhi_cntrl,
goto err_unmap;
}
- desc->callback = pci_epf_mhi_dma_callback;
- desc->callback_param = &complete;
+ dmaengine_desc_set_callback(desc, pci_epf_mhi_dma_callback, NULL,
+ &complete);
cookie = dmaengine_submit(desc);
ret = dma_submit_error(cookie);
@@ -414,8 +414,8 @@ static int pci_epf_mhi_edma_write(struct mhi_ep_cntrl *mhi_cntrl,
goto err_unmap;
}
- desc->callback = pci_epf_mhi_dma_callback;
- desc->callback_param = &complete;
+ dmaengine_desc_set_callback(desc, pci_epf_mhi_dma_callback, NULL,
+ &complete);
cookie = dmaengine_submit(desc);
ret = dma_submit_error(cookie);
@@ -526,8 +526,8 @@ static int pci_epf_mhi_edma_read_async(struct mhi_ep_cntrl *mhi_cntrl,
transfer->dir = DMA_FROM_DEVICE;
memcpy(&transfer->buf_info, buf_info, sizeof(*buf_info));
- desc->callback = pci_epf_mhi_dma_async_callback;
- desc->callback_param = transfer;
+ dmaengine_desc_set_callback(desc, pci_epf_mhi_dma_async_callback, NULL,
+ transfer);
cookie = dmaengine_submit(desc);
ret = dma_submit_error(cookie);
@@ -600,8 +600,8 @@ static int pci_epf_mhi_edma_write_async(struct mhi_ep_cntrl *mhi_cntrl,
transfer->dir = DMA_TO_DEVICE;
memcpy(&transfer->buf_info, buf_info, sizeof(*buf_info));
- desc->callback = pci_epf_mhi_dma_async_callback;
- desc->callback_param = transfer;
+ dmaengine_desc_set_callback(desc, pci_epf_mhi_dma_async_callback, NULL,
+ transfer);
cookie = dmaengine_submit(desc);
ret = dma_submit_error(cookie);
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] PCI: epf-mhi: use dmaengine_desc_set_callback()
2026-11-02 19:55 [PATCH 1/1] PCI: epf-mhi: use dmaengine_desc_set_callback() Frank.Li
@ 2026-11-02 20:00 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-02 20:00 UTC (permalink / raw)
To: Frank.Li, open list:PCI ENDPOINT SUBSYSTEM
> From: Frank Li <Frank.Li@nxp.com>
>
> Replace open-coded assignments to callback and callback_param fields of
> struct dma_async_tx_descriptor with calls to the
> dmaengine_desc_set_callback() helper.
>
> No functional change intended. Prepare to make struct
> dma_async_tx_descriptor private to the DMA engine.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261102195534.4088523-1-Frank.Li@oss.nxp.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-02 20:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-02 19:55 [PATCH 1/1] PCI: epf-mhi: use dmaengine_desc_set_callback() Frank.Li
2026-11-02 20:00 ` sashiko-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.