* [PATCH v3] dt-bindings: serial: ingenic: Add the X1600
@ 2026-11-02 20:14 Olivier Louvignes
2026-11-02 20:19 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Olivier Louvignes @ 2026-11-02 20:14 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Jiri Slaby, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Cercueil, H . Nikolaus Schaller, linux-serial, devicetree,
linux-mips, linux-kernel, Olivier Louvignes, Krzysztof Kozlowski
The X1600's UARTs have the X1000's registers and 64-byte FIFOs. Add
ingenic,x1600-uart, with the X1000's as fallback.
Signed-off-by: Olivier Louvignes <olivier@mgcrea.io>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
Changes since v2:
- Drop the driver patch that set UMR and UACR at probe. After a reset
the X1600's UMR already reads 16: the 0 the manual gives is what a
clock-gated UART reads, which is also what Nikolaus saw from U-Boot.
What needs fixing is a value a boot loader leaves (the HiBy R1's sets
8 on UART2, its console), which is the boot loader's business, as
Nikolaus said, not the X1600's.
- Move the new entry last, sorted by fallback (Krzysztof).
- Add Krzysztof's Acked-by.
v2: https://lore.kernel.org/all/20261024220712.23250-1-olivier@mgcrea.io/
v1: https://lore.kernel.org/all/20261024051515.55639-1-olivier@mgcrea.io/
Documentation/devicetree/bindings/serial/ingenic,uart.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/serial/ingenic,uart.yaml b/Documentation/devicetree/bindings/serial/ingenic,uart.yaml
index d5f153bdeb0d..0c452f20e103 100644
--- a/Documentation/devicetree/bindings/serial/ingenic,uart.yaml
+++ b/Documentation/devicetree/bindings/serial/ingenic,uart.yaml
@@ -35,6 +35,9 @@ properties:
- items:
- const: ingenic,jz4755-uart
- const: ingenic,jz4750-uart
+ - items:
+ - const: ingenic,x1600-uart
+ - const: ingenic,x1000-uart
reg:
maxItems: 1
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] dt-bindings: serial: ingenic: Add the X1600
2026-11-02 20:14 [PATCH v3] dt-bindings: serial: ingenic: Add the X1600 Olivier Louvignes
@ 2026-11-02 20:19 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-11-02 20:19 UTC (permalink / raw)
To: Olivier Louvignes; +Cc: linux-serial
> The X1600's UARTs have the X1000's registers and 64-byte FIFOs. Add
> ingenic,x1600-uart, with the X1000's as fallback.
>
> Signed-off-by: Olivier Louvignes <olivier@mgcrea.io>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261102201459.49284-1-olivier@mgcrea.io?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-02 20:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-02 20:14 [PATCH v3] dt-bindings: serial: ingenic: Add the X1600 Olivier Louvignes
2026-11-02 20:19 ` sashiko-bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.