[PATCH 0/3] kbuild: don't print DESCEND messages from tools/ build

[PATCH 0/3] kbuild: don't print DESCEND messages from tools/ build

[Thomas Weißschuh]

kbuild itself does not print the directories it descends into, the
tools/ build however does so. When kbuild executes the tools/ build
these messages are out of place.

Forward kbuild's behavior to the tools/ build:
Nothing is printed by default, the full command is printed with V=1.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
Thomas Weißschuh (3):
      tools/build: Deduplicate the descend commands
      kbuild: drop the tools/ target
      kbuild: don't print DESCEND messages from tools/ build

 Makefile                       | 6 +-----
 tools/scripts/Makefile.include | 7 ++-----
 2 files changed, 3 insertions(+), 10 deletions(-)
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261029-kbuild-descend-spam-fb01adf7e985

Best regards,
--  
Thomas Weißschuh <linux@weissschuh.net>

[PATCH 1/3] tools/build: Deduplicate the descend commands

[Thomas Weißschuh]

The verbose and non-verbose variants of the descend command are nearly
identical. Only the 'echo DESCEND' is different.

Simplify the variable definitions to be more similar to the other QUIET
commands.

This will also simplify some other changes down the line.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 tools/scripts/Makefile.include | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/tools/scripts/Makefile.include b/tools/scripts/Makefile.include
index 378387f62960..db989830bbac 100644
--- a/tools/scripts/Makefile.include
+++ b/tools/scripts/Makefile.include
@@ -206,7 +206,7 @@ export quiet Q
 # Call by doing: $(call descend,directory[,target])
 #
 descend = \
-	+mkdir -p $(OUTPUT)$(1) && \
+	+$(QUIET_DESCEND)mkdir -p $(OUTPUT)$(1) && \
 	$(MAKE) $(COMMAND_O) subdir=$(if $(subdir),$(subdir)/$(1),$(1)) $(PRINT_DIR) -C $(1) $(2)
 
 QUIET_SUBDIR0  = +$(MAKE) $(COMMAND_O) -C # space to separate -C and subdir
@@ -229,10 +229,7 @@ ifneq ($(silent),1)
 	QUIET_BISON    = @echo '  BISON   '$@;
 	QUIET_GENSKEL  = @echo '  GENSKEL '$@;
 
-	descend = \
-		+@echo	       '  DESCEND '$(1); \
-		mkdir -p $(OUTPUT)$(1) && \
-		$(MAKE) $(COMMAND_O) subdir=$(if $(subdir),$(subdir)/$(1),$(1)) $(PRINT_DIR) -C $(1) $(2)
+	QUIET_DESCEND  = @echo '  DESCEND '$(1);
 
 	QUIET_CLEAN    = @printf '  CLEAN   %s\n' $1;
 	QUIET_INSTALL  = @printf '  INSTALL %s\n' $1;

-- 
2.56.0

[PATCH 2/3] kbuild: drop the tools/ target

[Thomas Weißschuh]

The target is unusable as it gets overridden by the $(single-no-ko)
target. The only thing it would do is to print the help message.

$ make tools/
Makefile:2218: warning: overriding recipe for target 'tools/'
Makefile:1639: warning: ignoring old recipe for target 'tools/'

Drop the target.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 Makefile | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/Makefile b/Makefile
index f895752d4b05..d73f2bbd3b93 100644
--- a/Makefile
+++ b/Makefile
@@ -1635,10 +1635,6 @@ ifneq ($(wildcard $(bootconfig_O)),)
 	$(Q)$(MAKE) -sC $(srctree)/tools/bootconfig O=$(bootconfig_O) clean
 endif
 
-tools/: FORCE
-	$(Q)mkdir -p $(objtree)/tools
-	$(Q)$(MAKE) O=$(abspath $(objtree)) subdir=tools -C $(srctree)/tools/
-
 tools/%: FORCE
 	$(Q)mkdir -p $(objtree)/tools
 	$(Q)$(MAKE) O=$(abspath $(objtree)) subdir=tools -C $(srctree)/tools/ $*

-- 
2.56.0

[PATCH 3/3] kbuild: don't print DESCEND messages from tools/ build

[Thomas Weißschuh]

kbuild itself does not print the directories it descends into, the
tools/ build however does so. When kbuild executes the tools/ build
these messages are out of place.

Forward kbuild's behavior to the tools/ build:
Nothing is printed by default, the full command is printed with V=1.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index d73f2bbd3b93..2bfe786bc284 100644
--- a/Makefile
+++ b/Makefile
@@ -1637,7 +1637,7 @@ endif
 
 tools/%: FORCE
 	$(Q)mkdir -p $(objtree)/tools
-	$(Q)$(MAKE) O=$(abspath $(objtree)) subdir=tools -C $(srctree)/tools/ $*
+	$(Q)$(MAKE) O=$(abspath $(objtree)) QUIET_DESCEND=$(Q) subdir=tools -C $(srctree)/tools/ $*
 
 # ---------------------------------------------------------------------------
 # Kernel selftest

-- 
2.56.0

Re: [PATCH 3/3] kbuild: don't print DESCEND messages from tools/ build

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kbuild: missing QUIET_DESCEND=$(Q) in explicit tools/bootconfig target
--

commit 7691301f76c95de2969936070a6b66297111591a
Author: Thomas Weißschuh <linux@weissschuh.net>

kbuild: don't print DESCEND messages from tools/ build

This commit passes QUIET_DESCEND=$(Q) to the tools/ sub-make invoked by the
tools/% pattern rule in the top-level Makefile so that Kbuild suppresses
the DESCEND messages emitted by the tools/ build system by default.

> diff --git a/Makefile b/Makefile
> index d73f2bbd3b93d..2bfe786bc2843 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1637,7 +1637,7 @@ endif
>  
>  tools/%: FORCE
>  	$(Q)mkdir -p $(objtree)/tools
> -	$(Q)$(MAKE) O=$(abspath $(objtree)) subdir=tools -C $(srctree)/tools/ $*
> +	$(Q)$(MAKE) O=$(abspath $(objtree)) QUIET_DESCEND=$(Q) subdir=tools -C $(srctree)/tools/ $*

[Severity: Low]
Should the explicit tools/bootconfig rule earlier in Makefile also pass
QUIET_DESCEND=$(Q)?

Makefile defines a dedicated target for tools/bootconfig that takes
precedence over the generic tools/% pattern rule when building with
CONFIG_CMDLINE_FROM_BOOTCONFIG=y (via prepare: tools/bootconfig) or when
running make tools/bootconfig directly:

Makefile:
tools/bootconfig: export CC := $(HOSTCC)
tools/bootconfig: FORCE
	$(Q)mkdir -p $(objtree)/tools
	$(Q)$(MAKE) O=$(abspath $(objtree)) subdir=tools -C $(srctree)/tools/ \
		bootconfig CROSS_COMPILE=

In tools/Makefile, the bootconfig target uses $(call descend,$@), which
expands $(QUIET_DESCEND):

tools/Makefile:
counter dma firewire hv guest bootconfig spi usb virtio mm bpf iio gpio objtool leds wmi firmware debugging tracing: FORCE
	$(call descend,$@)

Without QUIET_DESCEND=$(Q) on the tools/bootconfig recipe, won't Kbuild
still print the DESCEND bootconfig message during builds that invoke
tools/bootconfig?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102-kbuild-descend-spam-v1-0-caff4f840cb7@weissschuh.net?part=3