[PATCH] of: unittest: fix node leak in phandle remapping test

[PATCH] of: unittest: fix node leak in phandle remapping test

[Wentao Liang]

of_unittest_parse_phandle_with_args_map() obtains a reference on the
consumer node with of_find_node_by_path() and never releases it, not
even on the normal exit path. The error path taken when one of the
provider lookups fails also leaks the provider references acquired by
the preceding iterations.

Drop both sets of references.

Fixes: 357aa4b61c82 ("of: unittest: Add phandle remapping test")
Cc: stable@vger.kernel.org
Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
 drivers/of/unittest.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 8133c954d335..a6ac58b4d883 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -581,6 +581,9 @@ static void __init of_unittest_parse_phandle_with_args_map(void)
 	for (i = 0; i < ARRAY_SIZE(p); ++i) {
 		if (!p[i]) {
 			pr_err("missing testcase data\n");
+			while (i > 0)
+				of_node_put(p[--i]);
+			of_node_put(np);
 			return;
 		}
 		prefs[i] = OF_KREF_READ(p[i]);
@@ -711,6 +714,8 @@ static void __init of_unittest_parse_phandle_with_args_map(void)
 			 i, prefs[i], OF_KREF_READ(p[i]));
 		of_node_put(p[i]);
 	}
+
+	of_node_put(np);
 }
 
 static void __init of_unittest_property_string(void)
-- 
2.34.1

Re: [PATCH] of: unittest: fix node leak in phandle remapping test

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] of: unittest: leak of p[] nodes in of_unittest_parse_phandle_with_args_map()
--

commit 76085e24075478d56a6949c4d7365c6d0d60c538
Author: Wentao Liang <vulab@iscas.ac.cn>

of: unittest: fix node leak in phandle remapping test

This commit releases the device_node reference for the consumer node and
adds cleanup for the provider node references when a provider lookup fails
in of_unittest_parse_phandle_with_args_map().

> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index e255f54f4d760..f240b1175211b 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -578,6 +578,9 @@ static void __init of_unittest_parse_phandle_with_args_map(void)
>  	for (i = 0; i < ARRAY_SIZE(p); ++i) {
>  		if (!p[i]) {
>  			pr_err("missing testcase data\n");
> +			while (i > 0)
> +				of_node_put(p[--i]);
> +			of_node_put(np);
>  			return;
>  		}
>  		prefs[i] = OF_KREF_READ(p[i]);

[Severity: Medium]
Does this error path still leak device_node references in p[i + 1] through
p[5]?

In drivers/of/unittest.c:of_unittest_parse_phandle_with_args_map(), all six
provider nodes are looked up before the validation loop begins:

	p[0] = of_find_node_by_path("/testcase-data/phandle-tests/provider0");
	p[1] = of_find_node_by_path("/testcase-data/phandle-tests/provider1");
	p[2] = of_find_node_by_path("/testcase-data/phandle-tests/provider2");
	p[3] = of_find_node_by_path("/testcase-data/phandle-tests/provider3");
	p[4] = of_find_node_by_path("/testcase-data/phandle-tests/provider4");
	p[5] = of_find_node_by_path("/testcase-data/phandle-tests/provider5");
	for (i = 0; i < ARRAY_SIZE(p); ++i) {
		if (!p[i]) {

If p[i] is NULL for an earlier entry (for example p[0]) while subsequent
lookups in p[i + 1 .. 5] succeeded, unwinding only from i down to 0 leaves
the non-NULL references in the remaining elements of p[] unreleased.

Since of_node_put() safely accepts NULL pointers, should this loop over the
entire p[] array (and update the commit message, which currently states that
the references were acquired by preceding loop iterations)?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103104235.1373591-1-vulab@iscas.ac.cn?part=1

Re: [PATCH] of: unittest: fix node leak in phandle remapping test

[Krzysztof Kozlowski]

On Tue, 03 Nov 2026 10:42:35 +0000, Wentao Liang wrote:
> of_unittest_parse_phandle_with_args_map() obtains a reference on the
> consumer node with of_find_node_by_path() and never releases it, not
> even on the normal exit path. The error path taken when one of the
> provider lookups fails also leaks the provider references acquired by
> the preceding iterations.
> 
> Drop both sets of references.
> 
> Fixes: 357aa4b61c82 ("of: unittest: Add phandle remapping test")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
>  drivers/of/unittest.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Multiple things here:
1. Your team ignored completely previous feedback. Multiple times.

2. You use multiple identities with this email address, thus I doubt that we
   speak with an actual person.

3. Your bot does not even bother running checkpatch, right?

4. Nothing of this was reproduced nor tested.

5. Finally, the same feedback:
You sent multiple independent patches, to multiple independent
subsystems. The amount of these patches clearly suggest this was
AI generated and most likely not tested.

More importantly, you sent all this work without properly organizing
relevant patches into patchsets. This makes reviewing difficult
and might cause multiple reviewers to address the same issue.
Replying to the entire set is impossible and requires handling each
patch independently, instead of applying or discarding the set.
Maintainers also won't see the bigger picture of your work. Quite
worrying.

This is on the verge of hostile patch: bomb us with so many
contributions, we won't be able to handle them in efficient manner,
like responding ONCE to ask you to slow down.  Considering all this
is untested and LLM generated, I have even more doubts whether this
should be considered for review.

Please read kernel documentation BEFORE posting more work. It will
explain you how to identify subsystems, how to organize your work per
subsystem (so a patchset grouping multiple patches with a short cover
letter), how to document the issue discovery method and what was
or was not tested.

Best regards,
Krzysztof