All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v3 2/4] perf build: Add explicitly sequenced -lzstd to libbfd feature fallback
Date: Wed, 04 Nov 2026 04:37:02 +0000	[thread overview]
Message-ID: <sashiko-outbox-196657@kernel.org> (raw)
In-Reply-To: <20261104043006.1199857-3-irogers@google.com>

> Distributions like Fedora ship a statically compiled binutils libbfd
> that depends on zstd to decompress sections (e.g. undefined reference to
> 'ZSTD_decompress').
> 
> Since libbfd does not reliably distribute a .pc file for pkg-config,
> perf probes manual linker flag combinations in fallback chains (-lbfd
> -ldl -liberty -lz).
> 
> Extend the testing cascade in tools/perf/Makefile.config to check
> libbfd-liberty-z-zstd and append '-lbfd -lopcodes -liberty -lz -lzstd'
> when detected.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104043006.1199857-1-irogers@google.com?part=2


  reply	other threads:[~2026-11-04  4:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  4:30 [PATCH v3 0/4] tools build: Fixes for libbfd -lzstd dependency Ian Rogers
2026-11-04  4:30 ` [PATCH v3 1/4] tools build: Add explicitly sequenced -lzstd to libbfd feature fallback Ian Rogers
2026-11-04  4:37   ` sashiko-bot
2026-11-04  5:03   ` bot+bpf-ci
2026-11-04  4:30 ` [PATCH v3 2/4] perf " Ian Rogers
2026-11-04  4:37   ` sashiko-bot [this message]
2026-11-04  4:30 ` [PATCH v3 3/4] bpftool: " Ian Rogers
2026-11-04  4:34   ` sashiko-bot
2026-11-04  4:30 ` [PATCH v3 4/4] objtool: Add explicitly sequenced -lzstd to libopcodes fallback Ian Rogers
2026-11-04  4:32   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-196657@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=irogers@google.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.