Re: [PATCH v3 1/4] tools build: Add explicitly sequenced -lzstd to libbfd feature fallback

[sashiko-bot@kernel.org]

> Distributions like Fedora ship a statically compiled binutils libbfd
> that depends on zstd (along with libiberty and zlib) to decompress
> sections (e.g. undefined reference to 'ZSTD_decompress').
> 
> Commit 89d001d48ec7 ("tools build: Add zstd to the binutils library
> feature tests") added '|| $(BUILD_BFD) -lzstd' directly to
> test-libbfd.bin, test-libbfd-threadsafe.bin, and
> test-disassembler-four-args.bin. However, static libbfd requires
> '-liberty -lz -lzstd' together, and setting feature-libbfd=1 when extra
> libraries are needed causes callers (perf, bpftool) to link only '-lbfd
> -lopcodes' without '-lzstd'.
> 
> Restore test-libbfd.bin to test only $(BUILD_BFD), add the
> test-libbfd-liberty-z-zstd.bin feature test and
> FEATURE_GROUP_MEMBERS-libbfd entry, and append the '-liberty -lz -lzstd'
> fallback to test-libbfd-threadsafe.bin, test-disassembler-four-args.bin,
> and test-disassembler-init-styled.bin.
> 
> Fixes: 89d001d48ec7 ("tools build: Add zstd to the binutils library feature tests")
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104043006.1199857-1-irogers@google.com?part=1