From: sashiko-bot@kernel.org
To: "Sebastian Reichel" <sebastian.reichel@collabora.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v8 1/9] PCI: dw-rockchip: Fix LTSSM set functions
Date: Wed, 04 Nov 2026 23:53:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-198315@kernel.org> (raw)
In-Reply-To: <20261105-rockchip-pcie-system-suspend-v8-1-0434b4f373bc@collabora.com>
> Before the Rockchip PCIe driver has been switched over to the
> FIELD_PREP_WM16 macro, PCIE_CLIENT_ENABLE_LTSSM and
> PCIE_CLIENT_DISABLE_LTSSM were setting bits with a mask of 0xc = 0b1100,
> which means BIT 2 and BIT 3. After the conversion it only sets bit 2,
> with bit 3 being handled by a separate define named
> PCIE_CLIENT_LD_RQ_RST_GRT. Apparently the conversion missed to make use
> of this new macros resulting in the third bit not being set.
>
> Fixes: 30e919570581 ("PCI: dw-rockchip: Switch to FIELD_PREP_WM16 macro")
> Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261105-rockchip-pcie-system-suspend-v8-0-0434b4f373bc@collabora.com?part=1
next prev parent reply other threads:[~2026-11-04 23:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 23:47 [PATCH v8 0/9] PCI: dw-rockchip: add system suspend support Sebastian Reichel
2026-11-04 23:47 ` Sebastian Reichel
2026-11-04 23:47 ` [PATCH v8 1/9] PCI: dw-rockchip: Fix LTSSM set functions Sebastian Reichel
2026-11-04 23:47 ` Sebastian Reichel
2026-11-04 23:53 ` sashiko-bot [this message]
2026-11-04 23:47 ` [PATCH v8 2/9] PCI: dw-rockchip: Restore vpcie3v3 regulator handle Sebastian Reichel
2026-11-04 23:47 ` Sebastian Reichel
2026-11-04 23:54 ` sashiko-bot
2026-11-04 23:47 ` [PATCH v8 3/9] PCI: dw-rockchip: Move devm_phy_get out of phy_init Sebastian Reichel
2026-11-04 23:47 ` Sebastian Reichel
2026-11-04 23:55 ` sashiko-bot
2026-11-04 23:47 ` [PATCH v8 4/9] PCI: dw-rockchip: Add helper function for enhanced LTSSM control mode Sebastian Reichel
2026-11-04 23:47 ` Sebastian Reichel
2026-11-04 23:55 ` sashiko-bot
2026-11-04 23:47 ` [PATCH v8 5/9] PCI: dw-rockchip: Add helper function for controller mode Sebastian Reichel
2026-11-04 23:47 ` Sebastian Reichel
2026-11-04 23:54 ` sashiko-bot
2026-11-04 23:47 ` [PATCH v8 6/9] PCI: dw-rockchip: Add helper function for DDL indicator Sebastian Reichel
2026-11-04 23:47 ` Sebastian Reichel
2026-11-04 23:54 ` sashiko-bot
2026-11-04 23:47 ` [PATCH v8 7/9] PCI: dw-rockchip: Add pme_turn_off support Sebastian Reichel
2026-11-04 23:47 ` Sebastian Reichel
2026-11-04 23:56 ` sashiko-bot
2026-11-05 0:51 ` Shawn Lin
2026-11-05 0:51 ` Shawn Lin
2026-11-05 11:38 ` Sebastian Reichel
2026-11-05 11:38 ` Sebastian Reichel
2026-11-04 23:47 ` [PATCH v8 8/9] PCI: dw-rockchip: Set broken L1SS resume flag Sebastian Reichel
2026-11-04 23:47 ` Sebastian Reichel
2026-11-04 23:55 ` sashiko-bot
2026-11-04 23:47 ` [PATCH v8 9/9] PCI: dw-rockchip: Add system PM support Sebastian Reichel
2026-11-04 23:47 ` Sebastian Reichel
2026-11-05 3:08 ` [PATCH v8 0/9] PCI: dw-rockchip: add system suspend support Igor Velkov
2026-11-05 3:08 ` Igor Velkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-198315@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.