All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Andrey Albershteyn via Linux-f2fs-devel"
	<linux-f2fs-devel@lists.sourceforge.net>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [f2fs-dev] [PATCH v2 4/5] ext4: use I_VERITY_BUILDING instead of private flags
Date: Thu, 05 Nov 2026 12:01:52 +0000	[thread overview]
Message-ID: <sashiko-outbox-198984@kernel.org> (raw)
In-Reply-To: <20261105115532.613467-5-aalbersh@kernel.org>

> Now that the VFS tracks an inode whose Merkle tree is under construction
> via I_VERITY_BUILDING and handles the concurrent-enable guard in the
> generic fs-verity enable path, drop the per-filesystem runtime flags that
> duplicated this state.
> 
> Replace ext4 own helper ext4_verity_in_progress() with
> fsverity_is_building(), and remove the EXT4_STATE_VERITY_IN_PROGRESS
> flags. The IS_ENABLED() guard is fine to remove now as
> fsverity_is_building() has stub for disabled fsverity.
> 
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105115532.613467-1-aalbersh@kernel.org?part=4


WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot--- via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: "Andrey Albershteyn via Linux-f2fs-devel"
	<linux-f2fs-devel@lists.sourceforge.net>
Cc: sashiko-bot@kernel.org, linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [f2fs-dev] [PATCH v2 4/5] ext4: use I_VERITY_BUILDING instead of private flags
Date: Thu, 05 Nov 2026 12:01:52 +0000	[thread overview]
Message-ID: <sashiko-outbox-198984@kernel.org> (raw)
In-Reply-To: <20261105115532.613467-5-aalbersh@kernel.org>

> Now that the VFS tracks an inode whose Merkle tree is under construction
> via I_VERITY_BUILDING and handles the concurrent-enable guard in the
> generic fs-verity enable path, drop the per-filesystem runtime flags that
> duplicated this state.
> 
> Replace ext4 own helper ext4_verity_in_progress() with
> fsverity_is_building(), and remove the EXT4_STATE_VERITY_IN_PROGRESS
> flags. The IS_ENABLED() guard is fine to remove now as
> fsverity_is_building() has stub for disabled fsverity.
> 
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105115532.613467-1-aalbersh@kernel.org?part=4



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2026-11-05 12:01 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 11:55 [PATCH v2 0/5] fsverity: lift ioctl() input masking and runtime inode flag to VFS Andrey Albershteyn
2026-11-05 11:55 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-05 11:55 ` [PATCH v2 1/5] fsverity: strip FS_VERITY_FL from FS_IOC_SETFLAGS Andrey Albershteyn
2026-11-05 11:55   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-05 12:03   ` sashiko-bot
2026-11-05 12:03     ` sashiko-bot--- via Linux-f2fs-devel
2026-11-06 10:26   ` Christoph Hellwig
2026-11-06 10:26     ` [f2fs-dev] " Christoph Hellwig
2026-11-05 11:55 ` [PATCH v2 2/5] fsverity: add I_VERITY_BUILDING inode state flag Andrey Albershteyn
2026-11-05 11:55   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-05 12:03   ` sashiko-bot
2026-11-05 12:03     ` sashiko-bot--- via Linux-f2fs-devel
2026-11-06 10:26   ` Christoph Hellwig
2026-11-06 10:26     ` [f2fs-dev] " Christoph Hellwig
2026-11-05 11:55 ` [PATCH v2 3/5] btrfs: use I_VERITY_BUILDING instead of private flags Andrey Albershteyn
2026-11-05 11:55   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-05 12:03   ` sashiko-bot
2026-11-06 10:26   ` Christoph Hellwig
2026-11-06 10:26     ` [f2fs-dev] " Christoph Hellwig
2026-11-05 11:55 ` [PATCH v2 4/5] ext4: " Andrey Albershteyn
2026-11-05 11:55   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-05 12:01   ` sashiko-bot [this message]
2026-11-05 12:01     ` sashiko-bot--- via Linux-f2fs-devel
2026-11-06 10:27   ` Christoph Hellwig
2026-11-06 10:27     ` [f2fs-dev] " Christoph Hellwig
2026-11-05 11:55 ` [PATCH v2 5/5] f2fs: " Andrey Albershteyn
2026-11-05 11:55   ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-11-05 12:03   ` sashiko-bot
2026-11-05 12:03     ` sashiko-bot--- via Linux-f2fs-devel
2026-11-06 10:27   ` Christoph Hellwig
2026-11-06 10:27     ` [f2fs-dev] " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-198984@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.