Re: [PATCH v2 2/3] thermal/drivers/amlogic: add S4 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] thermal: amlogic: redundant amlogic,s4-thermal match entry
--

commit d73de7ad59dbf743cca9b086493290c2c74eb121
Author: Christian Stefan Kövér-Draxl <ckoever@outlook.de>

thermal/drivers/amlogic: add S4 support

This commit adds a match table entry for "amlogic,s4-thermal" to
of_amlogic_thermal_match[], using the existing amlogic_thermal_t7_param
configuration.

> diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c
> index 60728de6968ac..4c107b3100c0d 100644
> --- a/drivers/thermal/amlogic_thermal.c
> +++ b/drivers/thermal/amlogic_thermal.c
> @@ -292,6 +292,10 @@ static const struct of_device_id of_amlogic_thermal_match[] = {
>  		.compatible = "amlogic,a1-cpu-thermal",
>  		.data = &amlogic_thermal_a1_cpu_param,
>  	},
> +	{
> +		.compatible = "amlogic,s4-thermal",
> +		.data = &amlogic_thermal_t7_param,
> +	},
>  	{
>  		.compatible = "amlogic,t7-thermal",
>  		.data = &amlogic_thermal_t7_param,

[Severity: Low]
As reported by Krzysztof Kozlowski on v1 [1], is a separate
"amlogic,s4-thermal" entry in of_amlogic_thermal_match[] needed when it uses
the exact same amlogic_thermal_t7_param data and binding constraints as
"amlogic,t7-thermal"?  Pairing "amlogic,s4-thermal" with "amlogic,t7-thermal"
as a fallback compatible in the Devicetree binding would make this driver
change unnecessary.

[1] https://lore.kernel.org/r/20261030-funny-ibex-of-modernism-b995fe@quoll

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106101913.46664-1-christian.koever-draxl@student.uibk.ac.at?part=2