Re: [PATCH v3 04/13] ARM: stm32: enable arm smc watchdog on stm32mp1xx

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ARM: stm32: selecting WATCHDOG and ARM_SMC_WATCHDOG forces
  built-in config
--

commit 4450302b23f46b760d6b23f33c853eaddb3d821b
Author: Antonio Borneo <antonio.borneo@foss.st.com>

ARM: stm32: enable arm smc watchdog on stm32mp1xx

This commit selects WATCHDOG and ARM_SMC_WATCHDOG from ARCH_STM32 when
ARCH_MULTI_V7 is enabled.

> diff --git a/arch/arm/mach-stm32/Kconfig b/arch/arm/mach-stm32/Kconfig
> index 4ac3384e397aa..de09b2afa0f2e 100644
> --- a/arch/arm/mach-stm32/Kconfig
> +++ b/arch/arm/mach-stm32/Kconfig
> @@ -13,6 +13,8 @@ menuconfig ARCH_STM32
>  	select RESET_CONTROLLER
>  	select STM32_EXTI if ARM_SINGLE_ARMV7M
>  	select STM32_FIREWALL
> +	select WATCHDOG if ARCH_MULTI_V7
> +	select ARM_SMC_WATCHDOG if ARCH_MULTI_V7
>  	help
>  	  Support for STMicroelectronics STM32MP1 processors using Cortex-A7
>  	  cores. Note that support for the earlier Cortex-M based variants

[Severity: Low]
Does selecting WATCHDOG and the tristate ARM_SMC_WATCHDOG from the boolean
ARCH_STM32 force both symbols to y whenever ARCH_MULTI_V7 is enabled?  That
prevents building arm_smc_wdt as a loadable module or disabling the driver
and watchdog subsystem on multi-platform ARMv7 kernels with ARCH_STM32
enabled.

Could ARM_SMC_WATCHDOG instead use a default in drivers/watchdog/Kconfig
(the way STM32_WATCHDOG uses default ARCH_STM32) or be enabled in the
relevant defconfig?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106163429.618392-1-antonio.borneo@foss.st.com?part=4