Re: [PATCH v3 10/13] arm64: dts: st: add iwdg1 and iwdg2 support to stm32mp211

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] arm64: dts: st: broken stm32mp215f-dk.dtb build from missing
  rcc header and node
- [Low] arm64: dts: st: undocumented access-controllers property on
  stm32mp1-iwdg nodes
--

commit 67f7dc5ddb768e993fdbc244a39bc4cf2ffdfc02
Author: Clément Le Goffic <clement.legoffic@foss.st.com>

arm64: dts: st: add iwdg1 and iwdg2 support to stm32mp211

This commit adds the iwdg1 and iwdg2 watchdog device tree nodes to
stm32mp211.dtsi.

> diff --git a/arch/arm64/boot/dts/st/stm32mp211.dtsi b/arch/arm64/boot/dts/st/stm32mp211.dtsi
> index 4bfd58b26b51b..7ad1c3c304dea 100644
> --- a/arch/arm64/boot/dts/st/stm32mp211.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp211.dtsi
> @@ -110,6 +110,26 @@ usart2: serial@400e0000 {
>  				access-controllers = <&rifsc 32>;
>  				status = "disabled";
>  			};
> +
> +			iwdg1: watchdog@44010000 {
> +				compatible = "st,stm32mp1-iwdg";
> +				reg = <0x44010000 0x0 0x400>;
> +				interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&rcc CK_BUS_IWDG1>, <&scmi_clk CK_SCMI_LSI>;

[Severity: High]
Does this break building stm32mp215f-dk.dtb?

Neither stm32mp211.dtsi nor the files including it include
dt-bindings/clock/st,stm32mp21-rcc.h, leaving CK_BUS_IWDG1, CK_BUS_IWDG2
(in iwdg2 below) and CK_SCMI_LSI unexpanded.  In addition, both nodes
reference &rcc, which is not defined in stm32mp211.dtsi or its include
hierarchy.

> +				clock-names = "pclk", "lsi";
> +				access-controllers = <&rifsc 100>;
> +				status = "disabled";
> +			};
> +
> +			iwdg2: watchdog@44020000 {
> +				compatible = "st,stm32mp1-iwdg";
> +				reg = <0x44020000 0x0 0x400>;
> +				interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&rcc CK_BUS_IWDG2>, <&scmi_clk CK_SCMI_LSI>;
> +				clock-names = "pclk", "lsi";
> +				access-controllers = <&rifsc 101>;

[Severity: Low]
Should Documentation/devicetree/bindings/watchdog/st,stm32-iwdg.yaml
allow the access-controllers property?  Because that schema sets
unevaluatedProperties: false and only references watchdog.yaml#,
dtbs_check will report access-controllers as an unevaluated property on
both iwdg1 and iwdg2.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261106163429.618392-1-antonio.borneo@foss.st.com?part=10