Re: [PATCH v3 9/9] kobject: Require explicit initialization of struct kobj_type::release

[sashiko-bot@kernel.org]

> Documentation/core-api/kobject.rst states:
> 
>   "One important point cannot be overstated: every kobject must have a
>   release() method, and the kobject must persist (in a consistent state)
>   until that method is called. If these constraints are not met, the code
>   is flawed. Note that the kernel will warn you if you forget to provide
>   a release() method. Do not try to get rid of this warning by providing
>   an \"empty\" release function."
> 
> Annotate struct kobj_type::release with __must_init so the compiler
> diagnoses any struct kobj_type initializer that omits .release.
> 
> For the remaining legacy struct kobj_type definitions where the kobject
> is static, per-CPU, a permanent firmware structure, or embedded inside a
> devm- or parent-managed allocation rather than freed by kobject_put(),
> explicitly initialize .release = NULL with a comment documenting why no
> release callback is provided.
> 
> Many of these legacy sites are not safe with CONFIG_DEBUG_KOBJECT_RELEASE
> (for example when backing memory is freed, zeroed, or unmapped on module
> unload while delayed kobject cleanup is still pending). Fixing those
> lifetimes is left to follow-up patches; this change does not alter their
> behavior.
> 
> Link: https://lpc.events/event/20/contributions/2392/
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261108223913.3624571-1-irogers@google.com?part=9