Re: [PATCH v3 7/9] ubifs: sysfs: Use kset_create_and_add() for ubifs_kset - sashiko-bot

From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Kees Cook" <kees@kernel.org>, "Miguel Ojeda" <ojeda@kernel.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>
Cc: "Madhavan Srinivasan" <maddy@linux.ibm.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Christophe Leroy" <chleroy@kernel.org>,
	"Nayna Jain" <nayna@linux.ibm.com>,
	"Srish Srinivasan" <ssrish@linux.ibm.com>,
	"Mimi Zohar" <zohar@linux.ibm.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Rich Felker" <dalias@libc.org>,
	"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
	"Juergen Gross" <jgross@suse.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Oleksandr Tyshchenko" <oleksandr_tyshchenko@epam.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Zhongqiu Han" <zhongqiu.han@oss.qualcomm.com>,
	"Alexander Aring" <aahringo@redhat.com>,
	"Felix Kuehling" <felix.kuehling@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Zhihao Cheng" <chengzhihao1@huawei.com>,
	"Sumanth Korikkar" <sumanthk@linux.ibm.com>,
	"Bill Wendling" <morbo@google.com>,
	"Justin Stitt" <justinstitt@google.com>,
	linux-s390@vger.kernel.org, linux-mtd@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v3 7/9] ubifs: sysfs: Use kset_create_and_add() for ubifs_kset
Date: Sun, 08 Nov 2026 23:10:42 +0000	[thread overview]
Message-ID: <sashiko-outbox-204152@kernel.org> (raw)
In-Reply-To: <20261108223913.3624571-8-irogers@google.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ubifs: sysfs: inaccurate Fixes trailer in commit message
--

commit 05ad573fa4719a7a6e36bb8dcf3c9060b5c194b0
Author: Ian Rogers <irogers@google.com>

> ubifs: sysfs: Use kset_create_and_add() for ubifs_kset
>
> ubifs_kset was a static struct kset using a custom ubifs_ktype that
> had no default_groups and no .release callback. With
> CONFIG_DEBUG_KOBJECT_RELEASE=y, unloading the ubifs module while delayed
> kobject release is pending causes a use-after-free on the static kset.
>
> Replace the static ubifs_kset and empty ubifs_ktype with a dynamically
> allocated kset via kset_create_and_add().
>
> Fixes: 203a55f04f66 ("ubifs: Fix memory leak in ubifs_sysfs_init()")
> Tested-by: Zhihao Cheng <chengzhihao1@huawei.com>
> Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> Signed-off-by: Ian Rogers <irogers@google.com>

[Severity: Low]
203a55f04f66 ("ubifs: Fix memory leak in ubifs_sysfs_init()") only added
an error-path kset_put() when kset_register() fails.  The static
ubifs_kset, ubifs_ktype without a release callback, and kset_unregister()
on module exit were introduced in 2e3cbf425804 ("ubifs: Export filesystem
error counters").

Should the Fixes tag instead be:

  Fixes: 2e3cbf425804 ("ubifs: Export filesystem error counters")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261108223913.3624571-1-irogers@google.com?part=7

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/