Re: [PATCH 17/17] arm64: dts: qcom: Add Samsung Galaxy XR - sashiko-bot

From: sashiko-bot@kernel.org
To: "Stanislav Aleksandrov" <lightofmysoul@gmail.com>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Abel Vesa" <abelvesa@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Robert Marko" <robimarko@gmail.com>,
	"Guru Das Srinagesh" <linux@gurudas.dev>,
	"Thomas Gleixner" <tglx@kernel.org>,
	"Radu Rendec" <radu@rendec.net>, "Lee Jones" <lee@kernel.org>,
	"Will Deacon" <will@kernel.org>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Joerg Roedel (AMD)" <joro@8bytes.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Wesley Cheng" <wesley.cheng@oss.qualcomm.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Bart Van Assche" <bvanassche@acm.org>,
	"Bean Huo" <beanhuo@micron.com>,
	"Stanley Jhu" <stanleyjhu@google.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Amit Kucheria" <amitk@kernel.org>,
	"Thara Gopinath" <thara.gopinath@gmail.com>,
	"Daniel Lezcano" <daniel.lezcano@kernel.org>,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Lukasz Luba" <lukasz.luba@arm.com>,
	"Georgi Djakov" <djakov@kernel.org>,
	"Sibi Sankar" <sibi.sankar@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, mfd@lists.linux.dev,
	linux-usb@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-scsi@vger.kernel.org, linux-crypto@vger.kernel.org,
	olteanv@gmail.com
Subject: Re: [PATCH 17/17] arm64: dts: qcom: Add Samsung Galaxy XR
Date: Mon, 09 Nov 2026 00:57:03 +0000	[thread overview]
Message-ID: <sashiko-outbox-204265@kernel.org> (raw)
In-Reply-To: <20261109-halliday-dts-v1-17-289114ab8197@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: invalid chassis-type value in
  halliday-samsung-xrvst2.dts
--

commit d2d9cbc7744fd9c3d95a63b1d3df85d5cbe99afb
Author: Stanislav Aleksandrov <lightofmysoul@gmail.com>

arm64: dts: qcom: Add Samsung Galaxy XR

This commit adds the device tree for the Samsung Galaxy XR headset based
on the Qualcomm Halliday SoC (SXR2250P).

> diff --git a/arch/arm64/boot/dts/qcom/halliday-samsung-xrvst2.dts b/arch/arm64/boot/dts/qcom/halliday-samsung-xrvst2.dts
> new file mode 100644
> index 0000000000000..6fcc1aaafd59c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/halliday-samsung-xrvst2.dts
> @@ -0,0 +1,218 @@
[ ... ]
> +/ {
> +	model = "Samsung Galaxy XR";
> +	compatible = "samsung,xrvst2", "qcom,halliday";
> +	chassis-type = "headset";

[Severity: Low]
Is "headset" a valid value for chassis-type in the root node?  The
Devicetree Specification and dtschema (schemas/root-node.yaml) only permit
desktop, laptop, convertible, server, tablet, handset, watch, embedded,
television, and all-in-one, so dtbs_check fails on this DTB unless a
standard value (such as "embedded") is used or chassis-type is omitted.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-halliday-dts-v1-0-289114ab8197@gmail.com?part=17