From: sashiko-bot@kernel.org
To: "Tiezhu Yang" <yangtiezhu@loongson.cn>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 2/2] selftests/bpf: Fix unaligned access failure in fexit_bpf2bpf
Date: Mon, 09 Nov 2026 04:17:48 +0000 [thread overview]
Message-ID: <sashiko-outbox-204400@kernel.org> (raw)
In-Reply-To: <20261109041207.15221-3-yangtiezhu@loongson.cn>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests/bpf: missing Fixes trailer for commit 6dc03dc71387
--
commit 507288d3c1afad0bf83be8f5f5a571a1da547ccc
Author: Tiezhu Yang <yangtiezhu@loongson.cn>
> selftests/bpf: Fix unaligned access failure in fexit_bpf2bpf
>
> When executing "./test_progs -t fexit_bpf2bpf", there are 5 subtest
> failures on platforms where CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
> is not set, because these platforms lack hardware unaligned access
> support:
>
> ; tcp->check++; @ test_pkt_access.c:98
> 226: (69) r1 = *(u16 *)(r2 +16)
> misaligned packet access off 2+(0x0; 0x3f)+16 size 2
> ...
> libbpf: prog 'test_pkt_access': failed to load: -EACCES
> libbpf: failed to load object './test_pkt_access.bpf.o'
>
> Instead of skipping these tests entirely, fix this at the source by
> applying a bitmask 'off &= ~1' right after the initial range check.
> This explicitly communicates the 2-byte alignment state to pass the
> verifier and run the full fexit_bpf2bpf test matrix.
>
> Before:
> $ sudo ./test_progs -t fexit_bpf2bpf | tail -1
> Summary: 0/10 PASSED, 1 SKIPPED, 1/5 FAILED
>
> After:
> $ sudo ./test_progs -t fexit_bpf2bpf | tail -1
> Summary: 1/15 PASSED, 1 SKIPPED, 0/0 FAILED
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
[Severity: Low]
This fixes the unaligned packet offset in test_pkt_write_access_subprog()
and new_test_pkt_write_access_subprog(). Should this include:
Fixes: 6dc03dc71387 ("selftests/bpf: Add test for freplace program with write access")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109041207.15221-1-yangtiezhu@loongson.cn?part=2
next prev parent reply other threads:[~2026-11-09 4:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 4:12 [PATCH bpf-next v2 0/2] selftests/bpf: Handle some unexpected failures Tiezhu Yang
2026-11-09 4:12 ` [PATCH bpf-next v2 1/2] selftests/bpf: Skip jit_insns_arena tests if not supported Tiezhu Yang
2026-11-09 4:25 ` sashiko-bot
2026-11-09 6:10 ` Tiezhu Yang
2026-11-09 4:12 ` [PATCH bpf-next v2 2/2] selftests/bpf: Fix unaligned access failure in fexit_bpf2bpf Tiezhu Yang
2026-11-09 4:17 ` sashiko-bot [this message]
2026-11-09 6:11 ` Tiezhu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-204400@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.