Re: [PATCH bpf-next v2 1/2] selftests/bpf: Skip jit_insns_arena tests if not supported

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests/bpf: incomplete jit_insns_arena skip list in
  test_jit_insns()
--

commit 5301df7df06ac60c33f099fbdfa02a082cfa0c99
Author: Tiezhu Yang <yangtiezhu@loongson.cn>

selftests/bpf: Skip jit_insns_arena tests if not supported

This commit probes for BPF_MAP_TYPE_ARENA support in test_jit_insns() and
skips the jit_insns_arena subtests when arena maps are not supported.

> diff --git a/tools/testing/selftests/bpf/prog_tests/jit_insns.c b/tools/testing/selftests/bpf/prog_tests/jit_insns.c
> index 0aaab23a2eef8..e8a0e5ec2d6bf 100644
> --- a/tools/testing/selftests/bpf/prog_tests/jit_insns.c
> +++ b/tools/testing/selftests/bpf/prog_tests/jit_insns.c
> @@ -3688,7 +3688,14 @@ static void test_tail_call(void)
>  
>  void test_jit_insns(void)
>  {
> -	RUN_TESTS(jit_insns_arena);
> +	if (libbpf_probe_bpf_map_type(BPF_MAP_TYPE_ARENA, NULL)) {
> +		RUN_TESTS(jit_insns_arena);
> +	} else {
> +		if (test__start_subtest("arena_zero_off"))
> +			test__skip();
> +		if (test__start_subtest("cast_to_user"))
> +			test__skip();
> +	}

[Severity: Low]
Does this else branch miss the remaining subtests in jit_insns_arena?

Commit a9fee553d3db ("selftests/bpf: Extend the JIT instruction tests for
arm64 encodings") added arena_offsets (built on all architectures) as well as
arena_offsets_ldsx, arena_offsets_atomics, and arena_acq_rel to
tools/testing/selftests/bpf/progs/jit_insns_arena.c.  When BPF_MAP_TYPE_ARENA
is unsupported, those subtests are silently omitted rather than registered and
marked skipped, so targeted runs such as ./test_progs -a
jit_insns/arena_offsets match zero subtests.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109041207.15221-1-yangtiezhu@loongson.cn?part=1