Re: [PATCH v4 1/2] dmaengine: qcom: gpi: Add trace event support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dmaengine: qcom: gpi: trace_gpi_irq_status() outside loop in
  gpi_handle_irq()
--

commit d58f53a2d6e27d4e15eb4d5e08cf8036404a5c06
Author: Praveen Talari <praveen.talari@oss.qualcomm.com>

dmaengine: qcom: gpi: Add trace event support

This commit adds tracepoint definitions and trace calls to the Qualcomm
GPI DMA engine driver.

> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index c41bfac65ddf3..fafe6ac848d94 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c
[ ... ]
> @@ -841,6 +846,7 @@ static irqreturn_t gpi_handle_irq(int irq, void *data)
>  
>  	offset = GPII_n_CNTXT_TYPE_IRQ_OFFS(gpii->gpii_id);
>  	type = gpi_read_reg(gpii, gpii->regs + offset);
> +	trace_gpi_irq_status(gpii->gpi_dev->dev, gpii_id, type);
>  
>  	do {
>  		/* global gpii error */

[Severity: Low]
Should trace_gpi_irq_status() be called inside the start of the
do-while(type) loop instead of before it?  At the end of the loop body,
gpi_handle_irq() re-reads GPII_n_CNTXT_TYPE_IRQ_OFFS into type, so any
newly asserted interrupt bits handled in subsequent iterations are not
recorded by trace_gpi_irq_status().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-add-trace-support-gpio-v4-0-85ed08134917@oss.qualcomm.com?part=1