Re: [PATCH v4 2/2] dmaengine: qcom: gpi: Convert dev_dbg() calls to tracepoints

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dmaengine: qcom: gpi: bare default label in
  gpi_process_events()
--

commit 5129f82faa3a23c9f80811290603ff518d6e73fb
Author: Praveen Talari <praveen.talari@oss.qualcomm.com>

dmaengine: qcom: gpi: Convert dev_dbg() calls to tracepoints

This commit replaces the remaining dev_dbg() calls in the Qualcomm GPI DMA
driver with tracepoints.

> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c
> index fafe6ac848d94..8f9e55e52c616 100644
> --- a/drivers/dma/qcom/gpi.c
> +++ b/drivers/dma/qcom/gpi.c

[ ... ]

> @@ -1121,11 +1105,8 @@ static void gpi_process_events(struct gpii *gpii)
>  							    &gpi_event->immediate_data_event);
>  				break;
>  			case QUP_NOTIF_EV_TYPE:
> -				dev_dbg(gpii->gpi_dev->dev, "QUP_NOTIF_EV_TYPE\n");
>  				break;
>  			default:
> -				dev_dbg(gpii->gpi_dev->dev,
> -					"not supported event type:0x%x\n", type);
>  			}
>  			gpi_ring_recycle_ev_element(ev_ring);
>  		}

[Severity: Medium]
Does removing dev_dbg() from the default: case in gpi_process_events()
leave a label at the end of the switch block without a break statement?
Under -std=gnu11, GCC versions prior to GCC 11 reject a bare label before
a closing brace with a build error.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-add-trace-support-gpio-v4-0-85ed08134917@oss.qualcomm.com?part=2