From: sashiko-bot@kernel.org
To: "Joseph Telaak" <joseph@telaak.dev>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH v2 01/11] leds: rgb: ktd202x: Fix the flash period of short blinks on 32 bit
Date: Mon, 09 Nov 2026 19:07:39 +0000 [thread overview]
Message-ID: <sashiko-outbox-205458@kernel.org> (raw)
In-Reply-To: <20261109-ktd202x-et6326-v2-1-56e97c226658@telaak.dev>
> From: Joseph Telaak <joseph@telaak.dev>
>
> When delay_on + delay_off is below 256 ms, the unsigned subtraction of
> KTD202X_FLASH_PERIOD_MIN_MS wraps. On 64 bit the result truncates to -1
> or -2 and gets clamped to the shortest period, but on 32 bit it
> truncates to 33554431 or 33554430 and gets clamped to the longest one,
> so asking for a fast blink gives a blink every 16 seconds.
>
> Compare before subtracting.
>
> Fixes: 0ebdb7210943 ("leds: Add ktd202x driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Joseph Telaak <joseph@telaak.dev>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261109-ktd202x-et6326-v2-0-56e97c226658@telaak.dev?part=1
next prev parent reply other threads:[~2026-11-09 19:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 19:03 [PATCH v2 00/11] leds: ktd202x: Add Etek ET6326, hardware breathing and fixes Joseph Telaak
2026-11-09 19:03 ` Joseph Telaak via B4 Relay
2026-11-09 19:03 ` [PATCH v2 01/11] leds: rgb: ktd202x: Fix the flash period of short blinks on 32 bit Joseph Telaak
2026-11-09 19:03 ` Joseph Telaak via B4 Relay
2026-11-09 19:07 ` sashiko-bot [this message]
2026-11-09 19:03 ` [PATCH v2 02/11] leds: rgb: ktd202x: Fix an out-of-bounds read with unused channels Joseph Telaak
2026-11-09 19:03 ` Joseph Telaak via B4 Relay
2026-11-09 19:10 ` sashiko-bot
2026-11-09 19:03 ` [PATCH v2 03/11] leds: rgb: ktd202x: Never program an on time of zero Joseph Telaak
2026-11-09 19:03 ` Joseph Telaak via B4 Relay
2026-11-09 19:08 ` sashiko-bot
2026-11-09 19:03 ` [PATCH v2 04/11] leds: rgb: ktd202x: Fix a division by zero with long blinks Joseph Telaak
2026-11-09 19:03 ` Joseph Telaak via B4 Relay
2026-11-09 19:09 ` sashiko-bot
2026-11-09 19:03 ` [PATCH v2 05/11] leds: rgb: ktd202x: Keep the unlit colors of a blinking LED off Joseph Telaak
2026-11-09 19:03 ` Joseph Telaak via B4 Relay
2026-11-09 19:10 ` sashiko-bot
2026-11-09 19:03 ` [PATCH v2 06/11] dt-bindings: leds: kinetic,ktd202x: Add Etek ET6326 Joseph Telaak
2026-11-09 19:03 ` Joseph Telaak via B4 Relay
2026-11-09 19:07 ` sashiko-bot
2026-11-09 19:03 ` [PATCH v2 07/11] leds: rgb: ktd202x: Add Etek ET6326 support Joseph Telaak
2026-11-09 19:03 ` Joseph Telaak via B4 Relay
2026-11-09 19:09 ` sashiko-bot
2026-11-09 19:03 ` [PATCH v2 08/11] leds: rgb: ktd202x: Add hardware pattern support Joseph Telaak
2026-11-09 19:03 ` Joseph Telaak via B4 Relay
2026-11-09 19:18 ` sashiko-bot
2026-11-09 19:03 ` [PATCH v2 09/11] leds: rgb: ktd202x: Limit the LED current to led-max-microamp Joseph Telaak
2026-11-09 19:03 ` Joseph Telaak via B4 Relay
2026-11-09 19:12 ` sashiko-bot
2026-11-09 19:03 ` [PATCH v2 10/11] leds: rgb: ktd202x: Fail the probe when the chip does not answer Joseph Telaak
2026-11-09 19:03 ` Joseph Telaak via B4 Relay
2026-11-09 19:13 ` sashiko-bot
2026-11-09 19:03 ` [PATCH v2 11/11] leds: rgb: ktd202x: Don't let a blinking LED retime another one Joseph Telaak
2026-11-09 19:03 ` Joseph Telaak via B4 Relay
2026-11-09 19:27 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-205458@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=joseph@telaak.dev \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.