Re: [PATCH v8 10/29] drm/msm/dp: add link_ready to manage link-level operations

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/msm/dp: misleading debug message in
  msm_dp_display_unprepare()
--

commit 88db74be5ac740123c07fc4d5b8d88136a13ec57
Author: Yongxing Mou <yongxing.mou@oss.qualcomm.com>

drm/msm/dp: add link_ready to manage link-level operations

This commit adds a link_ready flag to struct msm_dp so that link preparation
and teardown run only once when multiple streams share a DisplayPort link in
MST mode.

> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> index 471085744c7c2..6a522cc71a2ac 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c

[ ... ]

> @@ -1570,6 +1587,11 @@ void msm_dp_display_unprepare(struct msm_dp *msm_dp_display)
>  
>  	dp = container_of(msm_dp_display, struct msm_dp_display_private, msm_dp_display);
>  
> +	if (!msm_dp_display->link_ready) {
> +		drm_dbg_dp(dp->drm_dev, "Link already setup, return\n");
> +		return;
> +	}

[Severity: Low]
Should this debug message say that the link is not ready or has already
been torn down instead of "Link already setup, return"?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110-msm-dp-mst-v8-0-d040fb33db5f@oss.qualcomm.com?part=10