Re: [PATCH 06/20] ASoC: soc-component: makes regmap function to inline macro

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] ASoC: soc-component: undeclared snd_soc_component_to_regmap()
  breaks build
--

commit f289bf9367f01f6ee0716c3f431535b8a1efc6e9
Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

ASoC: soc-component: makes regmap function to inline macro

This commit moves snd_soc_component_regmap_val_bytes(),
snd_soc_component_regmap_cache_sync(), and
snd_soc_component_regmap_async_complete() from sound/soc/soc-component.c to
static inline helpers in include/sound/soc-component.h.

> diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h
> index 6d5740d5a5e21..4e538942df643 100644
> --- a/include/sound/soc-component.h
> +++ b/include/sound/soc-component.h
[ ... ]
> @@ -455,10 +448,53 @@ int snd_soc_pcm_component_ack(struct snd_pcm_substream *substream);
>  void snd_soc_pcm_component_delay(struct snd_pcm_substream *substream,
>  				 snd_pcm_sframes_t *cpu_delay, snd_pcm_sframes_t *codec_delay);
>  
> +/*
> + * regmap
> + */
> +void snd_soc_component_regmap_init(struct snd_soc_component *component,
> +				   struct regmap *regmap);
> +void snd_soc_component_regmap_exit(struct snd_soc_component *component);
> +
> +static inline int snd_soc_component_regmap_get_val_bytes(struct snd_soc_component *component)
> +{
> +	struct regmap *regmap = snd_soc_component_to_regmap(component);
> +	int val_bytes;
> +
> +	/* Errors are legitimate for non-integer byte multiples */
> +
> +	if (!regmap)
> +		return 0;
> +
> +	val_bytes = regmap_get_val_bytes(regmap);
> +	if (val_bytes < 0)
> +		return 0;
> +
> +	return val_bytes;
> +}
> +
> +static inline int snd_soc_component_regcache_sync(struct snd_soc_component *component)
> +{
> +	struct regmap *regmap = snd_soc_component_to_regmap(component);
> +
> +	if (!regmap)
> +		return 0;
> +
> +	return regcache_sync(regmap);
> +}
> +
> +static inline void snd_soc_component_regmap_async_complete(struct snd_soc_component *component)
> +{
> +	struct regmap *regmap = snd_soc_component_to_regmap(component);
> +
> +	if (regmap)
> +		regmap_async_complete(regmap);
> +}

[Severity: High]
Does calling snd_soc_component_to_regmap() in these three static inline
functions break compilation at this commit?

snd_soc_component_to_regmap() is not declared or defined until a later patch
in the series, commit "ASoC: soc-component: add
snd_soc_component_to_regmap()".  Because these helpers are static inline
functions rather than macros, every translation unit that includes
include/sound/soc-component.h fails to compile with an implicit function
declaration error until that patch is applied, breaking git bisect across
the intermediate commits.  Ordering commit "ASoC: soc-component: add
snd_soc_component_to_regmap()" before this patch would keep the series
bisectable.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/878q31nttj.wl-kuninori.morimoto.gx@renesas.com?part=6