Re: [PATCH 16/20] ASoC: soc-component: add snd_soc_component_regmap_multi_reg_write_bypassed()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] ASoC: build failure in
  snd_soc_component_regmap_multi_reg_write_bypassed()
--

commit 57b5a81c5a120fd92608fae86a8fb5b252d6cb73
Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

ASoC: soc-component: add snd_soc_component_regmap_multi_reg_write_bypassed()

This commit adds the snd_soc_component_regmap_multi_reg_write_bypassed()
static inline helper to wrap regmap_multi_reg_write_bypassed() on a
component's regmap.

> diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h
> index 89ae650b74f87..0a8beebd7b038 100644
> --- a/include/sound/soc-component.h
> +++ b/include/sound/soc-component.h
> @@ -489,6 +489,19 @@ static inline int snd_soc_component_regcache_sync(struct snd_soc_component *comp
>  	return regcache_sync(regmap);
>  }
>  
> +static inline int
> +snd_soc_component_regmap_multi_reg_write_bypassed(struct snd_soc_component *component,
> +						  const struct reg_sequence *regs,
> +						  int num_regs)
> +{
> +	struct regmap *regmap = snd_soc_component_to_regmap(component);
> +
> +	if (!regmap)
> +		return 0;
> +
> +	return regmap_multi_reg_write_bypassed(regmap, regs, num_regs);
> +}

[Severity: High]
Does calling regmap_multi_reg_write_bypassed() from a static inline helper
break the build when regmap support is disabled?

Unlike regcache_sync() and the other helpers in this header,
include/linux/regmap.h only declares regmap_multi_reg_write_bypassed()
inside its #ifdef CONFIG_REGMAP block and provides no fallback stub in the
#else section.  Any translation unit that includes sound/soc-component.h
(or sound/soc.h) when regmap is disabled will fail to compile with an
implicit function declaration error.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/878q31nttj.wl-kuninori.morimoto.gx@renesas.com?part=16