Re: [PATCH net-next 08/12] dt-bindings: can: renesas,rcar-canfd: Restrict resets in top-level

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: can: renesas,rcar-canfd: duplicate reset-names:
  false in allOf
--

commit 673edc90f4112a3f288e1450d2ac3c1b416dd41b
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dt-bindings: can: renesas,rcar-canfd: Restrict resets in top-level

This commit constrains the top-level resets property to 1 or 2 items,
removes redundant maxItems: 2 entries in per-variant conditionals, and adds
reset-names: false to the renesas,rcar-gen3-canfd and
renesas,rcar-gen4-canfd conditional block.

Link: https://patch.msgid.link/20261001060825.53335-2-krzysztof.kozlowski@oss.qualcomm.com

> diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> index bbaaef8f4282e..1a7a9ce45e977 100644
> --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml
[ ... ]
> @@ -231,6 +232,8 @@ allOf:
>          resets:
>            maxItems: 1
>  
> +        reset-names: false

[Severity: Low]
Does this duplicate the reset-names: false constraint already present in a
second if-then block for the same compatible strings further down in allOf?

Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml:
  - if:
      properties:
        compatible:
          contains:
            enum:
              - renesas,rcar-gen3-canfd
              - renesas,rcar-gen4-canfd
    then:
      required:
        - resets
      properties:
        reset-names: false

These two identical if conditions for renesas,rcar-gen3-canfd and
renesas,rcar-gen4-canfd could be merged, or the binding could be split into
separate schema documents to avoid accumulating fragmented per-compatible
conditionals.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261110115112.3807247-1-mkl@pengutronix.de?part=8