All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] audit: add missing syscalls to signal class
@ 2026-11-11 15:20 Jeffrey Bencteux
  2026-11-11 16:27 ` sashiko-bot
  0 siblings, 1 reply; 3+ messages in thread
From: Jeffrey Bencteux @ 2026-11-11 15:20 UTC (permalink / raw)
  To: paul, eparis, arnd, audit; +Cc: linux-arch, linux-kernel, jeff, rrobaina

The pidfd_send_signal(), rt_sigqueueinfo() and rt_tgsigqueueinfo()
system calls are missing from the AUDIT_CLASS_SIGNAL* class. It seems
to be used only in kernel/auditfilter.c to increment the audit_signals
counter.

This counter is used to determine if information related to a target
process of a syscall audit rule using signals, such as its pid,
should be logged (e54dc2431d740a79a6bd013babade99d71b1714f).

Information related to signals sent via these system calls are
currently not correctly logged. The current patch adds it to the
AUDIT_CLASS_SIGNAL* class.

Signed-off-by: Jeffrey Bencteux <jeff@bencteux.fr>
---
Changes in v2:
- Removal of unneeded #ifdef guards

 include/asm-generic/audit_signal.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/asm-generic/audit_signal.h b/include/asm-generic/audit_signal.h
index 6feab7f18a53..c02edbee3311 100644
--- a/include/asm-generic/audit_signal.h
+++ b/include/asm-generic/audit_signal.h
@@ -1,3 +1,6 @@
 __NR_kill,
 __NR_tgkill,
 __NR_tkill,
+__NR_rt_sigqueueinfo,
+__NR_rt_tgsigqueueinfo,
+__NR_pidfd_send_signal,

base-commit: 6614d4c05c7a661a925b3d8dbf9c70faac3bd2da
-- 
2.56.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] audit: add missing syscalls to signal class
  2026-11-11 15:20 [PATCH v2] audit: add missing syscalls to signal class Jeffrey Bencteux
@ 2026-11-11 16:27 ` sashiko-bot
  2026-11-11 19:51   ` Ricardo Robaina
  0 siblings, 1 reply; 3+ messages in thread
From: sashiko-bot @ 2026-11-11 16:27 UTC (permalink / raw)
  To: audit

> The pidfd_send_signal(), rt_sigqueueinfo() and rt_tgsigqueueinfo()
> system calls are missing from the AUDIT_CLASS_SIGNAL* class. It seems
> to be used only in kernel/auditfilter.c to increment the audit_signals
> counter.
> 
> This counter is used to determine if information related to a target
> process of a syscall audit rule using signals, such as its pid,
> should be logged (e54dc2431d740a79a6bd013babade99d71b1714f).
> 
> Information related to signals sent via these system calls are
> currently not correctly logged. The current patch adds it to the
> AUDIT_CLASS_SIGNAL* class.
> 
> Signed-off-by: Jeffrey Bencteux <jeff@bencteux.fr>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111152057.59798-2-jeff@bencteux.fr?part=1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] audit: add missing syscalls to signal class
  2026-11-11 16:27 ` sashiko-bot
@ 2026-11-11 19:51   ` Ricardo Robaina
  0 siblings, 0 replies; 3+ messages in thread
From: Ricardo Robaina @ 2026-11-11 19:51 UTC (permalink / raw)
  To: sashiko-reviews; +Cc: audit

On Wed, Nov 11, 2026 at 1:36 PM <sashiko-bot@kernel.org> wrote:
>
> > The pidfd_send_signal(), rt_sigqueueinfo() and rt_tgsigqueueinfo()
> > system calls are missing from the AUDIT_CLASS_SIGNAL* class. It seems
> > to be used only in kernel/auditfilter.c to increment the audit_signals
> > counter.
> >
> > This counter is used to determine if information related to a target
> > process of a syscall audit rule using signals, such as its pid,
> > should be logged (e54dc2431d740a79a6bd013babade99d71b1714f).
> >
> > Information related to signals sent via these system calls are
> > currently not correctly logged. The current patch adds it to the
> > AUDIT_CLASS_SIGNAL* class.
> >
> > Signed-off-by: Jeffrey Bencteux <jeff@bencteux.fr>
>
> Sashiko has reviewed this patch and found no issues.
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20261111152057.59798-2-jeff@bencteux.fr?part=1
>
>

Looks good to me.

Reviewed-by: Ricardo Robaina <rrobaina@redhat.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-11 19:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-11 15:20 [PATCH v2] audit: add missing syscalls to signal class Jeffrey Bencteux
2026-11-11 16:27 ` sashiko-bot
2026-11-11 19:51   ` Ricardo Robaina

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.