Re: [PATCH 1/2] mfd: cs42l43: Add load detection register needed for cs42l43b

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] mfd: cs42l43: missing CS42L43B_LOAD_DET_SEL in
  cs42l43_readable_register()
--

commit 86bb228eefe713b198f8b6a31cc740c008b39cd7
Author: Charles Keepax <ckeepax@opensource.cirrus.com>

mfd: cs42l43: Add load detection register needed for cs42l43b

This commit defines the CS42L43B_LOAD_DET_SEL register and marks it as
precious in cs42l43_precious_register().

> diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c
> index a83b62064dae6..4e5d82c355ee3 100644
> --- a/drivers/mfd/cs42l43.c
> +++ b/drivers/mfd/cs42l43.c
> @@ -425,6 +425,7 @@ bool cs42l43_precious_register(struct device *dev, unsigned int reg)
>  	case CS42L43_RX_DATA:
>  	case CS42L43_DECIM_INT ... CS42L43_HPOUT_INT:
>  	case CS42L43_MCU_SW_REV ... CS42L43_MCU_RAM_MAX:
> +	case CS42L43B_LOAD_DET_SEL:
>  		return true;

[Severity: Medium]
Should CS42L43B_LOAD_DET_SEL also be added to cs42l43_readable_register()?

regmap_precious() and regmap_volatile() return false before invoking
cs42l43_precious_register() or cs42l43_volatile_register() when
cs42l43_readable_register() returns false.  As a result, writes to
CS42L43B_LOAD_DET_SEL during headphone load detection are treated as
non-volatile, cached in the maple tree regcache, and replayed to hardware on
every runtime PM resume during regcache_sync().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111171032.1491717-1-ckeepax@opensource.cirrus.com?part=1