Re: [PATCH 05/10] pinctrl: nuvoton: npcm8xx: Propagate npcm8xx_gpio_register() error in probe

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [Medium] pinctrl: nuvoton: iomap leak in npcm7xx_gpio_of() and
  npcm8xx_gpio_fw() [1]
--

commit 86095407b58f80f7127008d829c751165be4ce58
Author: Lee Jones <lee@kernel.org>

pinctrl: nuvoton: npcm8xx: Propagate npcm8xx_gpio_register() error in probe

This commit adds the missing return statement in npcm8xx_pinctrl_probe() so
that errors from npcm8xx_gpio_register() are propagated by dev_err_probe().

> diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
> index b695a682b4342..39fcd05fc522c 100644
> --- a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
> +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c
> @@ -2582,7 +2582,7 @@ static int npcm8xx_pinctrl_probe(struct platform_device *pdev)
>  
>  	ret = npcm8xx_gpio_register(pctrl);
>  	if (ret < 0)
> -		dev_err_probe(dev, ret, "Failed to register gpio\n");
> +		return dev_err_probe(dev, ret, "Failed to register gpio\n");

[Severity: Medium]
This problem wasn't introduced by this patch, but does returning an error here
(or on earlier error paths in npcm8xx_pinctrl_probe() and npcm7xx_pinctrl_probe())
leak the pctrl->gpio_bank[id].base MMIO mappings [1]?

npcm8xx_gpio_fw() and npcm7xx_gpio_of() map each bank's registers with
unmanaged fwnode_iomap(), and nothing calls iounmap() when a later bank
initialization step, devm_pinctrl_register(), or GPIO registration fails:

drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c:npcm8xx_gpio_fw() {
    ...
	for_each_gpiochip_node(dev, child) {
		pctrl->gpio_bank[id].base = fwnode_iomap(child, 0);
		if (!pctrl->gpio_bank[id].base)
			return dev_err_probe(dev, -ENXIO, "fwnode_iomap id %d failed\n", id);
    ...
}

[1] https://sashiko.dev/#/bug/linux-cf83b9c0-f3a2-4dc8-95a0-af6fafb6d092

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111215256.1982044-1-lee@kernel.org?part=5