From: sashiko-bot@kernel.org
To: "Lee Jones" <lee@kernel.org>, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 04/10] pinctrl: nuvoton: ma35: Avoid leaking map when parent node is missing
Date: Wed, 11 Nov 2026 22:34:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-209808@kernel.org> (raw)
In-Reply-To: <20261111215256.1982044-5-lee@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] pinctrl: nuvoton: ma35: inaccurate commit description of
3fd976afe974
--
commit 16d0fceb87809d6ff503501ddb36d785b4f12a75
Author: Lee Jones <lee@kernel.org>
pinctrl: nuvoton: ma35: Avoid leaking map when parent node is missing
This commit moves the parent device node lookup before allocating new_map in
ma35_pinctrl_dt_node_to_map_func() so that new_map is not leaked if
of_get_parent() returns NULL.
> Commit 3fd976afe974 ("pinctrl: nuvoton: fix a double free in
> ma35_pinctrl_dt_node_to_map_func()") removed the kfree(new_map) call on
> the !parent error path to avoid a double free, but left *map = new_map
> assigned before of_get_parent(np).
[Severity: Low]
Is this description of 3fd976afe974 ("pinctrl: nuvoton: fix a double free
in ma35_pinctrl_dt_node_to_map_func()") accurate?
There was never a kfree(new_map) call on the !parent error path.
3fd976afe974 ("pinctrl: nuvoton: fix a double free in
ma35_pinctrl_dt_node_to_map_func()") switched the allocation from
devm_kcalloc() to unmanaged kcalloc() without freeing new_map when
of_get_parent() fails.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111215256.1982044-1-lee@kernel.org?part=4
next prev parent reply other threads:[~2026-11-11 22:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 21:51 [PATCH 00/10] pinctrl: Fix resource leaks, out-of-bounds accesses, and error handling (batch 2) Lee Jones
2026-11-11 21:51 ` [PATCH 01/10] pinctrl: nuvoton: ma35: Unmap reg_base and release clock on probe error Lee Jones
2026-11-11 21:51 ` [PATCH 02/10] pinctrl: nuvoton: ma35: Prevent out-of-bounds write in ma35_pinctrl_get_soc_data() Lee Jones
2026-11-11 22:31 ` sashiko-bot
2026-11-11 21:51 ` [PATCH 03/10] pinctrl: nuvoton: ma35: Assign fwnode to gpio_chip in ma35_gpiolib_register() Lee Jones
2026-11-11 21:51 ` [PATCH 04/10] pinctrl: nuvoton: ma35: Avoid leaking map when parent node is missing Lee Jones
2026-11-11 22:34 ` sashiko-bot [this message]
2026-11-11 21:51 ` [PATCH 05/10] pinctrl: nuvoton: npcm8xx: Propagate npcm8xx_gpio_register() error in probe Lee Jones
2026-11-11 22:32 ` sashiko-bot
2026-11-11 21:51 ` [PATCH 06/10] pinctrl: nuvoton: npcm7xx: Fix fwnode_irq_get() error check in npcm7xx_gpio_of() Lee Jones
2026-11-11 21:51 ` [PATCH 07/10] pinctrl: single: Reject invalid register width in pcs_probe() Lee Jones
2026-11-11 21:51 ` [PATCH 08/10] pinctrl: single: Free pinconf settings array in pcs_dt_free_map() Lee Jones
2026-11-11 21:51 ` [PATCH 09/10] pinctrl: sunplus: Validate pin_func index in sppctl_dt_node_to_map() Lee Jones
2026-11-12 6:27 ` Andrew Gaylard
2026-11-11 21:51 ` [PATCH 10/10] pinctrl: realtek: rtd1625: Set dcycle_offset to NA for pins without duty-cycle support Lee Jones
2026-11-12 8:55 ` Yu-Chun Lin [林祐君]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-209808@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.