Re: [PATCH v4 04/19] liveupdate: Allow file handlers to mark retrieve failures as retryable

[sashiko-bot@kernel.org]

> From: Pasha Tatashin <pasha.tatashin@soleen.com>
> 
> Add a retryable output flag to struct liveupdate_file_op_args, which a
> handler's .retrieve() can set on error to tell LUO that it hasn't
> consumed the preserved state. LUO then lets userspace retry the
> retrieve, and .finish() still releases the preserved state if the file
> is never retrieved.
> 
> When luo_retrieve_file() invokes a handler's .retrieve() callback and it
> returns an error, LUO currently records the error in
> luo_file->retrieve_status and blocks any subsequent retrieve attempts.
> This is necessary when the handler has already partially consumed or
> freed the preserved KHO state.
> 
> However, with user arguments passed to .retrieve(), a handler may fail
> early while validating caller-supplied parameters, such as a missing or
> invalid argument, before touching any preserved KHO state. In such
> cases, userspace should be able to fix the argument and retry
> LIVEUPDATE_SESSION_RETRIEVE_FD.
> 
> Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>
> Signed-off-by: David Matlack <dmatlack@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111002358.1842967-1-dmatlack@google.com?part=4