Re: [PATCH net-next v1 04/15] psp: add support for socket-less psp associations

[sashiko-bot@kernel.org]

> currently, a psp association is bound to a tcp socket when it is
> created, and can hold both an rx and a tx key.
> 
> add a small registry of un-bound associations. These have either an rx
> or tx flavor, and are referenced by an id. other parts of the stack can
> then attach them to packets. see the subsequent patches, where the tc
> psp action does just this.
> 
> an rx association records the spi, version, and device key generation,
> primarily for describe (assoc-get). a tc filter matches these fields
> with the flower keys psp_spi, psp_ver, and psp_dev instead of
> referencing the association by id, to facilitate hw offload. these
> matches are added in a subsequent patch.
> 
> adds the following new netlink commands for managing these associations.
> [ ... ]
> 
> published associations are dropped from the registry when their psp
> device is unregistered.
> 
> Signed-off-by: Todd Freed <toddfreed@meta.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111005533.6436-1-toddfreed@meta.com?part=4