Re: [PATCH net-next v1 13/15] selftests: tc-testing: run dependsOn probes outside the test namespace

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] selftests: tc-testing: missing Fixes: trailer for dependsOn
  probe fix in run_one_test()
--

commit b366286cfdfd21956025890cdfcc1c16cfe59bd5
Author: Todd Freed <toddfreed@meta.com>

> selftests: tc-testing: run dependsOn probes outside the test namespace
>
> a test's dependsOn probe runs as an execute stage command, but is run
> before the test's namespace is created. nsPlugin prefixes the command
> with "ip netns exec tcut", which causes the command to fail. this makes
> every test with a probe that requires nsPlugin skipped currently. for
> example the mirred blockid tests and the tunnel_key nofrag test.
>
> probes are meant to check what tc and the kernel supports, not anything
> in the test's namespace. run them as their own stage ("probe"), which
> makes them run in the base namespace.
>
> Signed-off-by: Todd Freed <toddfreed@meta.com>

[Severity: Low]
Since this fixes dependsOn probes running with the "execute" stage after
per-test namespaces replaced the shared tcut namespace, consider adding a
Fixes: tag:

  Fixes: 98cfbe4234a4 ("selftests/tc-testing: localize test resources")
  Fixes: 7f3f86402609 ("selftests: tc-testing: add "depends_on" property to skip tests")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261111005533.6436-1-toddfreed@meta.com?part=13