Re: [PATCH v9 08/11] arm64: dts: qcom: ipq5210: Enable the PWM block

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: qcom: ipq5210: pwm node enabled in SoC DTSI instead
  of board DTSI
--

commit 2d83ac83097807a2fcd75eaf7c88a88dc70672e9
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

arm64: dts: qcom: ipq5210: Enable the PWM block

This commit adds the PWM controller node to the IPQ5210 SoC device tree
and configures its pinmux on the RDP504 common board file.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi
> index 02fb76283f7fa..87a7e625a2a41 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi
> @@ -89,6 +89,11 @@ &pcie1_port0 {
>  	reset-gpios = <&tlmm 29 GPIO_ACTIVE_LOW>;
>  };
>  
> +&pwm {
> +	pinctrl-0 = <&pwm_default_state>;
> +	pinctrl-names = "default";
> +};

[ ... ]

> diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> index aa1045f20ed20..4cb9f399d4808 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> @@ -431,6 +431,16 @@ tcsr: syscon@1937000 {
>  			reg = <0x0 0x01937000 0x0 0x2b000>;
>  		};
>  
> +		pwm: pwm@1941010 {
> +			compatible = "qcom,ipq5210-pwm", "qcom,ipq6018-pwm";
> +			reg = <0x0 0x01941010 0x0 0x20>;
> +			clocks = <&gcc GCC_ADSS_PWM_CLK>;
> +			assigned-clocks = <&gcc GCC_ADSS_PWM_CLK>;
> +			assigned-clock-rates = <100000000>;
> +			#pwm-cells = <3>;
> +			status = "okay";
> +		};

[Severity: Low]
Should pwm@1941010 have status = "disabled" here in ipq5210.dtsi, with
status = "okay" moved to the &pwm node in ipq5210-rdp504-common.dtsi?

The PWM pinmux is board-specific, and ipq_pwm_probe() calls
devm_clk_get_enabled() and devm_clk_rate_exclusive_get(), so enabling the
controller in the SoC DTSI keeps GCC_ADSS_PWM_CLK ungated and rate-locked
at 100 MHz on every IPQ5210 board even when PWM is unused.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-08-dts-v9-0-c34de4f78fbb@oss.qualcomm.com?part=8