Re: [PATCH v9 03/11] arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant DT file

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: ipq5210: identical root compatible on
  RDP504 NAND and eMMC
--

commit 073c305d3df5613ad5b8c3e588379e6b62b9fe9c
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant DT file

This commit adds a devicetree file for the IPQ5210 RDP504 NAND board
variant, enables QPIC NAND in quad mode, and adds the new DTB to the
Makefile.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts
> new file mode 100644
> index 0000000000000..1145fcf0a3025
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts
> @@ -0,0 +1,17 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +/dts-v1/;
> +
> +#include "ipq5210-rdp504-common.dtsi"
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. IPQ5210 RDP504 (NAND)";
> +	compatible = "qcom,ipq5210-rdp504", "qcom,ipq5210";
> +};

[Severity: Medium]
Should ipq5210-rdp504-nand.dts use a distinct board compatible string instead
of sharing "qcom,ipq5210-rdp504" with the eMMC variant in ipq5210-rdp504.dts?

In ipq5210-rdp504-common.dtsi, qpic_snand_default_state and
sdhc_default_state mux gpio0 through gpio5 to mutually exclusive functions for
NAND and eMMC.  When both DTBs are packaged in a multi-DTB image such as a FIT
image, a bootloader matching on the root compatible property cannot
distinguish between the two variants and may load the wrong DTB, causing
storage initialization to fail.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-08-dts-v9-0-c34de4f78fbb@oss.qualcomm.com?part=3