Re: [PATCH ath-next 02/15] wifi: ath12k: refactor PCI window selection to per-device layout

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] wifi: ath12k: hardcoded 0x3f window mask in
  ath12k_pcic_select_static_window()
--

commit bb1726c3a715437675ea3d3a7a6b0b741f959d92
Author: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>

wifi: ath12k: refactor PCI window selection to per-device layout

This commit moves PCI and AHB register window masks and register offsets into
per-device layout structures so device families with different window layouts
can configure their own window mapping.

> diff --git a/drivers/net/wireless/ath/ath12k/pcic.c b/drivers/net/wireless/ath/ath12k/pcic.c
> index b6d306fd3b99f..cd04b9531d912 100644
> --- a/drivers/net/wireless/ath/ath12k/pcic.c
> +++ b/drivers/net/wireless/ath/ath12k/pcic.c
[ ... ]
> @@ -32,7 +38,7 @@ static int ath12k_pcic_select_static_window(struct ath12k_base *ab, u32 addr)
>  	const int max_retries = 10;
>  	int i;
>  
> -	window_bits = u32_get_bits(addr, WINDOW_VALUE_MASK);
> +	window_bits = field_get(ab_ahb->reg_base->window_value_mask, addr);
>  
>  	/* Update window bits [5:0], preserving other bits */
>  	new_window = u32_replace_bits(ab_ahb->static_window_reg, window_bits, 0x3f);

[Severity: Medium]
Should ath12k_pcic_select_static_window() use
ab_ahb->reg_base->window_static_mask (like ath12k_pci_select_window() does)
instead of hardcoding 0x3f here?

Leaving 0x3f hardcoded leaves struct ath12k_ahb_reg_base::window_static_mask
unused across the driver and truncates window_bits to 6 bits on AHB/PCIC
devices whose dynamic window field is not bits [5:0], misprogramming the
window register during CMEM accesses.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-wifi8_qcn9575_bringup-v1-0-3f30fbc2bb69@oss.qualcomm.com?part=2