Re: [PATCH ath-next 15/15] wifi: ath12k: add Wi-Fi 8 PCI driver scaffolding for QCN9575

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] wifi: ath12k: missing arch_init and arch_deinit in
  ath12k_wifi8_pci_driver
--

commit ad19b62d9fe2e5840dd771d3681d43b9adc7965d
Author: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>

wifi: ath12k: add Wi-Fi 8 PCI driver scaffolding for QCN9575

This commit adds QCN9575 PCI window register constants, implements
ath12k_wifi8_pci_probe(), and registers ath12k_wifi8_pci_driver in
ath12k_wifi8_pci_init().

> diff --git a/drivers/net/wireless/ath/ath12k/wifi8/pci.c b/drivers/net/wireless/ath/ath12k/wifi8/pci.c
> index 3975081d167b8..fd0489f8333f4 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi8/pci.c
> +++ b/drivers/net/wireless/ath/ath12k/wifi8/pci.c
[ ... ]
> +static struct ath12k_pci_driver ath12k_wifi8_pci_driver = {
> +	.name = "ath12k_wifi8_pci",
> +	.id_table = ath12k_wifi8_pci_id_table,
> +	.ops.probe = ath12k_wifi8_pci_probe,
> +	.reg_base = &ath12k_wifi8_reg_base,
> +};
> +
>  int ath12k_wifi8_pci_init(void)
>  {
> -	/* Wi-Fi 8 PCI driver registration will be added in follow-up patches. */
> +	int ret;
> +
> +	ret = ath12k_pci_register_driver(ATH12K_DEVICE_FAMILY_WIFI8,
> +					 &ath12k_wifi8_pci_driver);
> +	if (ret) {
> +		pr_err("Failed to register ath12k Wi-Fi 8 driver: %d\n", ret);
> +		return ret;
> +	}
> +
>  	return 0;
>  }

[Severity: High]
Does ath12k_pci_register_driver() always fail here with -EINVAL because
ath12k_wifi8_pci_driver omits .ops.arch_init and .ops.arch_deinit?

drivers/net/wireless/ath/ath12k/pci.c:ath12k_pci_register_driver() {
	...
	if (!driver || !driver->ops.probe ||
	    !driver->ops.arch_init || !driver->ops.arch_deinit)
		return -EINVAL;
	...
}

With both callbacks left NULL, ath12k_wifi8_pci_init() fails and
prevents the ath12k_wifi8 module from loading.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112-wifi8_qcn9575_bringup-v1-0-3f30fbc2bb69@oss.qualcomm.com?part=15