From: sashiko-bot@kernel.org
To: "Manikandan Muralidharan" <manikandan.m@microchip.com>,
pratyush@kernel.org, mwalle@kernel.org,
takahiro.kuwano@infineon.com, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, srini@kernel.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@tuxon.dev, linux@armlinux.org.uk,
richardcochran@gmail.com, arnd@arndb.de, linusw@kernel.org,
enelsonmoore@gmail.com, aaro.koskinen@iki.fi,
pengpeng@iscas.ac.cn, mathieu.dubois-briand@bootlin.com,
gregkh@linuxfoundation.org, michael@walle.cc,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v10 3/8] nvmem: core: take a reference on dev.of_node in nvmem_register()
Date: Thu, 12 Nov 2026 11:57:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-211056@kernel.org> (raw)
In-Reply-To: <2bc9cde2ff5bfa2bc55bf12407bfc08f6a467bb6.1794391660.git.manikandan.m@microchip.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] nvmem: core: missing Fixes trailer for nvmem_register() of_node
reference fix
--
commit 34145a3067cdfbb6bf1220c524a41a448d6b7c85
Author: Manikandan Muralidharan <manikandan.m@microchip.com>
> nvmem: core: take a reference on dev.of_node in nvmem_register()
>
> nvmem_register() stores config->of_node (or config->dev->of_node)
> into nvmem->dev.of_node without taking its own reference. Callers
> that get the node via of_get_compatible_child() etc. and drop their
> reference right after registering leave nvmem->dev.of_node backed by
> no reference at all.
>
> Take an of_node_get() when assigning nvmem->dev.of_node and release
> it in nvmem_release(). Existing callers that hold their own get/put
> pair around the registration call need no changes, since get/put on
> a device_node is per-holder and independent of core now also holding
> one.
>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Reviewed-by: Michael Walle <mwalle@kernel.org>
> Suggested-by: Michael Walle <mwalle@kernel.org>
> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
[Severity: Low]
This fixes a missing device_node reference in nvmem_register(). Should
the commit message include a Fixes tag for the commit that introduced
config->of_node handling:
Fixes: 1333a6779501 ("nvmem: core: allow specifying of_node")
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794391660.git.manikandan.m@microchip.com?part=3
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Manikandan Muralidharan" <manikandan.m@microchip.com>,
pratyush@kernel.org, mwalle@kernel.org,
takahiro.kuwano@infineon.com, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, srini@kernel.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@tuxon.dev, linux@armlinux.org.uk,
richardcochran@gmail.com, arnd@arndb.de, linusw@kernel.org,
enelsonmoore@gmail.com, aaro.koskinen@iki.fi,
pengpeng@iscas.ac.cn, mathieu.dubois-briand@bootlin.com,
gregkh@linuxfoundation.org, michael@walle.cc,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v10 3/8] nvmem: core: take a reference on dev.of_node in nvmem_register()
Date: Thu, 12 Nov 2026 11:57:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-211056@kernel.org> (raw)
In-Reply-To: <2bc9cde2ff5bfa2bc55bf12407bfc08f6a467bb6.1794391660.git.manikandan.m@microchip.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] nvmem: core: missing Fixes trailer for nvmem_register() of_node
reference fix
--
commit 34145a3067cdfbb6bf1220c524a41a448d6b7c85
Author: Manikandan Muralidharan <manikandan.m@microchip.com>
> nvmem: core: take a reference on dev.of_node in nvmem_register()
>
> nvmem_register() stores config->of_node (or config->dev->of_node)
> into nvmem->dev.of_node without taking its own reference. Callers
> that get the node via of_get_compatible_child() etc. and drop their
> reference right after registering leave nvmem->dev.of_node backed by
> no reference at all.
>
> Take an of_node_get() when assigning nvmem->dev.of_node and release
> it in nvmem_release(). Existing callers that hold their own get/put
> pair around the registration call need no changes, since get/put on
> a device_node is per-holder and independent of core now also holding
> one.
>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Reviewed-by: Michael Walle <mwalle@kernel.org>
> Suggested-by: Michael Walle <mwalle@kernel.org>
> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
[Severity: Low]
This fixes a missing device_node reference in nvmem_register(). Should
the commit message include a Fixes tag for the commit that introduced
config->of_node handling:
Fixes: 1333a6779501 ("nvmem: core: allow specifying of_node")
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794391660.git.manikandan.m@microchip.com?part=3
next prev parent reply other threads:[~2026-11-12 11:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 11:55 [PATCH v10 0/8] Read MAC address from SST vendor specific SFDP region Manikandan Muralidharan
2026-11-11 11:55 ` Manikandan Muralidharan
2026-11-11 11:55 ` [PATCH v10 1/8] dt-bindings: mtd: jedec,spi-nor: allow the SFDP to be exposed via NVMEM Manikandan Muralidharan
2026-11-11 11:55 ` Manikandan Muralidharan
2026-11-11 11:55 ` [PATCH v10 2/8] dt-bindings: nvmem: layouts: add Microchip/SST SFDP EUI layout Manikandan Muralidharan
2026-11-11 11:55 ` Manikandan Muralidharan
2026-11-11 11:55 ` [PATCH v10 3/8] nvmem: core: take a reference on dev.of_node in nvmem_register() Manikandan Muralidharan
2026-11-11 11:55 ` Manikandan Muralidharan
2026-11-12 11:57 ` sashiko-bot [this message]
2026-11-12 11:57 ` sashiko-bot
2026-11-11 11:55 ` [PATCH v10 4/8] mtd: spi-nor: sfdp: expose the SFDP as a read-only NVMEM device Manikandan Muralidharan
2026-11-11 11:55 ` Manikandan Muralidharan
2026-11-12 11:57 ` sashiko-bot
2026-11-12 11:57 ` sashiko-bot
2026-11-11 11:55 ` [PATCH v10 5/8] nvmem: layouts: add Microchip/SST SFDP EUI layout driver Manikandan Muralidharan
2026-11-11 11:55 ` Manikandan Muralidharan
2026-11-11 11:55 ` [PATCH v10 6/8] ARM: dts: microchip: sama5d27_wlsom1: use fixed-partitions for QSPI flash Manikandan Muralidharan
2026-11-11 11:55 ` Manikandan Muralidharan
2026-11-11 11:55 ` [PATCH v10 7/8] ARM: dts: microchip: sama5d27_wlsom1: read MAC address from QSPI SFDP Manikandan Muralidharan
2026-11-11 11:55 ` Manikandan Muralidharan
2026-11-11 11:55 ` [PATCH v10 8/8] ARM: configs: sama5: enable Microchip/SST SFDP EUI NVMEM layout Manikandan Muralidharan
2026-11-11 11:55 ` Manikandan Muralidharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-211056@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=enelsonmoore@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=manikandan.m@microchip.com \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pengpeng@iscas.ac.cn \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=srini@kernel.org \
--cc=takahiro.kuwano@infineon.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.