[PATCH 0/3] drm/panel: ilitek-ili9881c: Fix Ampire, Startek, and TDO panels

[PATCH 0/3] drm/panel: ilitek-ili9881c: Fix Ampire, Startek, and TDO panels

[Philipp Zabel]

Those three panels got their number of lanes set to zero. Set the
number of lanes back to 4, to make them light up again. Tested with
the Ampire AM8001280G panel.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
Philipp Zabel (3):
      drm/panel: ilitek-ili9881c: Fix Ampire AM8001280G support
      drm/panel: ilitek-ili9881c: Fix Startek KD050HDFIA020-C020A support
      drm/panel: ilitek-ili9881c: Fix TDO TL050HDV35 support

 drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 3 +++
 1 file changed, 3 insertions(+)
---
base-commit: 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
change-id: 20261113-panel-ilitek9881c-lanes-b68167d8d33d

Best regards,
--  
Philipp Zabel <p.zabel@pengutronix.de>

[PATCH 1/3] drm/panel: ilitek-ili9881c: Fix Ampire AM8001280G support

[Philipp Zabel]

Add back the missing number of lanes for Ampire AM8001280G panels.

Fixes: 2f7e4a699736 ("drm/panel: ilitek-ili9881c: Allow configuration of the number of lanes")
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index 7bf38e96678a..cc4cd646b611 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -2662,6 +2662,7 @@ static const struct ili9881c_desc am8001280g_desc = {
 	.mode = &am8001280g_default_mode,
 	.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
 		      MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,
+	.lanes = 4,
 };
 
 static const struct ili9881c_desc rpi_5inch_desc = {

-- 
2.47.3

[PATCH 2/3] drm/panel: ilitek-ili9881c: Fix Startek KD050HDFIA020-C020A support

[Philipp Zabel]

Add back the missing number of lanes for Startek KD050HDFIA020-C020A
panels.

Fixes: 2f7e4a699736 ("drm/panel: ilitek-ili9881c: Allow configuration of the number of lanes")
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index cc4cd646b611..4b68dcf319d4 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -2627,6 +2627,7 @@ static const struct ili9881c_desc kd050hdfia020_desc = {
 	.mode = &kd050hdfia020_default_mode,
 	.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
 		      MIPI_DSI_MODE_LPM,
+	.lanes = 4,
 };
 
 static const struct ili9881c_desc tl050hdv35_desc = {

-- 
2.47.3

[PATCH 3/3] drm/panel: ilitek-ili9881c: Fix TDO TL050HDV35 support

[Philipp Zabel]

Add back the missing number of lanes for TDO TL050HDV35 panels.

Fixes: 2f7e4a699736 ("drm/panel: ilitek-ili9881c: Allow configuration of the number of lanes")
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
---
 drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index 4b68dcf319d4..444d41b3d1c9 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -2637,6 +2637,7 @@ static const struct ili9881c_desc tl050hdv35_desc = {
 	.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
 		      MIPI_DSI_MODE_LPM,
 	.default_address_mode = 0x03,
+	.lanes = 4,
 };
 
 static const struct ili9881c_desc w552946aaa_desc = {

-- 
2.47.3

Re: [PATCH 1/3] drm/panel: ilitek-ili9881c: Fix Ampire AM8001280G support

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [High] drm/panel: ilitek-ili9881c: missing lanes init in three panel
  descriptors [1]
--

commit 40a8a814e1b52ccce761f231179cd2bd05641a2c
Author: Philipp Zabel <p.zabel@pengutronix.de>

drm/panel: ilitek-ili9881c: Fix Ampire AM8001280G support

This commit sets .lanes = 4 in am8001280g_desc to restore the lane count
for Ampire AM8001280G panels.

> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> index 7bf38e96678ac..cc4cd646b6111 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> @@ -2662,6 +2662,7 @@ static const struct ili9881c_desc am8001280g_desc = {
>  	.mode = &am8001280g_default_mode,
>  	.mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
>  		      MIPI_DSI_CLOCK_NON_CONTINUOUS | MIPI_DSI_MODE_LPM,
> +	.lanes = 4,
>  };

[Severity: High]
This problem wasn't introduced by this patch, but are kd050hdfia020_desc
and tl050hdv35_desc also missing their .lanes initializer from
2f7e4a699736 ("drm/panel: ilitek-ili9881c: Allow configuration of the
number of lanes") [1]?

Without .lanes set, ili9881c_dsi_probe() passes dsi->lanes == 0 to
mipi_dsi_attach(), causing DSI host attachment to fail with -EINVAL or
triggering a division by zero in DSI host controller drivers that divide
by dsi->lanes.

[1] https://sashiko.dev/#/bug/linux-62dd6149-f822-4521-aeee-730978e33590

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113-panel-ilitek9881c-lanes-v1-0-9d9320cc1387@pengutronix.de?part=1