Re: [PATCH 04/10] perf jevents: Encapsulate big_c_string lookups behind pmu_events__get_string()

[sashiko-bot@kernel.org]

> Replace direct &big_c_string[offset] indexing in decompress_event(),
> decompress_metric(), and describe_metricgroup() with calls to
> pmu_events__get_string(uint32_t offset), and change compact_pmu_event
> and metricgroups offsets to uint32_t.
> 
> When generating a single file (such as empty-pmu-events.c), emit
> pmu_events__get_string() as a static inline helper indexing
> static const char big_c_string[]. When generating separate pmu-events.c
> and pmu-events-string.c files, keep big_c_string static to
> pmu-events-string.c and expose pmu_events__get_string() across the two
> generated translation units. Also add explicit POSIX standard header
> inclusions to the generated C files.
> 
> This cleanly isolates the string storage representation inside
> pmu-events-string.c so subsequent patches can replace flat byte offsets
> into big_c_string[] with block-indexed string compression (where each
> uint32_t offset encodes (block_id << 16) | sub_offset into independently
> compressed ~8 KiB blocks decompressed on demand) without changing
> pmu-events.c.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113210822.3112700-1-irogers@google.com?part=4