Re: [PATCH 10/10] perf build: Default JEVENTS_ARCH to all

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] perf test: unused make_jevents_all variable left in
  tools/perf/tests/make
--

commit bc0eaefa256c7f8aa5fcdfd94d8c39345c28c3f0
Author: Ian Rogers <irogers@google.com>

perf build: Default JEVENTS_ARCH to all

This commit changes the default JEVENTS_ARCH setting from the host
architecture to all, enabling cross-architecture PMU event and metric
tables by default, and updates the build test suite to exercise single-arch
builds via JEVENTS_ARCH=$(SRCARCH).

> diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> index 5a04f67257acd..b69ddc9e1489a 100644
> --- a/tools/perf/tests/make
> +++ b/tools/perf/tests/make
> @@ -77,6 +77,7 @@ make_clang_nondistro := CC=clang BUILD_NONDISTRO=1
>  make_extra_tests    := EXTRA_TESTS=1
>  make_no_jevents     := NO_JEVENTS=1
>  make_jevents_all    := JEVENTS_ARCH=all
> +make_jevents_arch   := JEVENTS_ARCH=$(SRCARCH)
>  make_jevents_compress_none := JEVENTS_COMPRESS=none
>  make_no_bpf_skel    := BUILD_BPF_SKEL=0
>  make_gen_vmlinux_h  := GEN_VMLINUX_H=1
> @@ -172,7 +173,7 @@ endif
>  endif
>  run += make_extra_tests
>  run += make_no_jevents
> -run += make_jevents_all
> +run += make_jevents_arch
>  run += make_jevents_compress_none
>  run += make_no_bpf_skel
>  run += make_gen_vmlinux_h

[Severity: Low]
Should the make_jevents_all definition be removed now that $(run) replaces
it with make_jevents_arch and leaves it unreferenced?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113210822.3112700-1-irogers@google.com?part=10