Re: [PATCH 2/4] hwmon: (adt7475) Convert to hwmon_device_register_with_info()

[sashiko-bot@kernel.org]

> Convert the driver from hwmon_device_register_with_groups() to
> hwmon_device_register_with_info(). The standard voltage, temperature,
> fan and PWM attributes move to hwmon_ops. The chip-specific attributes
> stay driver-defined and are passed as extra groups: the automatic fan
> control points, temperature smoothing, PWM stall disable,
> pwm_use_point2_pwm_at_crit and the VID attributes.
> 
> The driver keeps data->lock, although the hwmon core serialises the
> hwmon_ops callbacks. The attributes in the extra groups run outside that
> serialisation, and they share the register cache and its periodic update
> with the hwmon_ops callbacks. They do not take hwmon_lock() instead, to
> keep this conversion free of locking changes.
> 
> The sysfs attribute names, permissions, values and register writes are
> unchanged. This was checked with i2c-stub on all four chip types and
> several register images, comparing the attribute list, every value read
> and written, and the final register contents before and after the
> conversion.
> 
> The hwmon core parses the standard attributes with kstrtol() and
> returns its error, which gives two differences for input that is out of
> range:
> - Writing a number that does not fit in a long now fails with -ERANGE
>   instead of -EINVAL.
> - fanN_min was parsed with kstrtoul(), so values above LONG_MAX were
>   accepted (and set the lowest limit). They now fail with -ERANGE. On
>   32-bit systems this applies from 2147483648 rpm, far beyond any real
>   fan.
> 
> Signed-off-by: Davíð Steinn Geirsson <david@dsg.is>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114004110.328050-1-david@dsg.is?part=2