Re: [PATCH net-next 1/3] dt-bindings: net: dptel,dap8211r: add led nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: net: dptel,dap8211r: invalid and ineffective
  leds node schema
--

commit b253b1562298deb66ca7a0d9739c668ef65e6592
Author: Artem Shimko <a.shimko.dev@gmail.com>

dt-bindings: net: dptel,dap8211r: add led nodes

This commit documents the optional leds node and adds an example for the
DAP8211R PHY binding.

> diff --git a/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml b/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml
> index 4cd0f9730d954..43425fc8e96e0 100644
> --- a/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml
> +++ b/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml

[ ... ]

> @@ -28,6 +29,22 @@ properties:
>    compatible:
>      const: ethernet-phy-id0008.011b
>  
> +  leds:
> +    type: object
> +    description:
> +      Optional node describing the three configurable LEDs of the PHY.
> +      Each LED can be assigned a color, function and default trigger
> +      (e.g. "netdev" for link/activity indication).
> +    patternProperties:
> +      '^led@[0-2]$':
> +        type: object
> +        properties:
> +          reg:
> +            maxItems: 1
> +        required:
> +          - reg
> +        additionalProperties: true

[Severity: Medium]
Does this leds schema pass dt_binding_check or enforce the 0..2 LED index
limit?

The leds object omits additionalProperties: false (as well as
#address-cells and #size-cells), and ^led@[0-2]$ sets
additionalProperties: true without a compatible property, both of which
fail DT meta-schema validation.

Because ethernet-phy.yaml# is included in allOf and already defines leds
with ^led@[a-f0-9]+$, leaving additionalProperties unset on leds allows
child nodes outside ^led@[0-2]$ (such as led@3) to pass validation via
ethernet-phy.yaml#, while reg under ^led@[0-2]$ only specifies maxItems: 1
without restricting the value to 0..2.

Either drop the leds property block to inherit the definition from
ethernet-phy.yaml#, or define #address-cells, #size-cells, and
additionalProperties: false on leds and reference
/schemas/leds/common.yaml# with unevaluatedProperties: false and
maximum: 2 on reg under ^led@[0-2]$.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113110546.173624-1-a.shimko.dev@gmail.com?part=1