Re: [PATCH net-next 2/3] net: phy: dap8211r: add extended register write helper

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] net: phy: dap8211r: inverted locking comment on
  dap8211r_write_ext()
--

commit 80c461dbd61c7143cfae371b80c6ab5797de75b3
Author: Artem Shimko <a.shimko.dev@gmail.com>

net: phy: dap8211r: add extended register write helper

This commit adds the dap8211r_write_ext() helper to write extended PHY
registers via indirect addressing.

> diff --git a/drivers/net/phy/dap8211r.c b/drivers/net/phy/dap8211r.c
> index 0bf770f8ebbb4..4eb50c26397fb 100644
> --- a/drivers/net/phy/dap8211r.c
> +++ b/drivers/net/phy/dap8211r.c
> @@ -88,6 +88,32 @@ static int dap8211r_read_ext(struct phy_device *phydev, u16 reg)
>  	return ret;
>  }
>  
> +/**
> + * dap8211r_write_ext() - Write extended register
> + * @phydev: PHY device structure
> + * @reg: Extended register address
> + * @data: Data to write
> + *
> + * Writes a PHY extended register using the indirect access method.
> + * The caller must hold the MDIO bus lock.
> + *
> + * Return: 0 on success, or negative error code
> + */
> +static int dap8211r_write_ext(struct phy_device *phydev, u16 reg, u16 data)
> +{
> +	int ret;
> +
> +	phy_lock_mdio_bus(phydev);
> +	ret = __phy_write(phydev, DAP8211R_EXT_ADD, reg);
> +	if (ret < 0)
> +		goto out;
> +
> +	ret = __phy_write(phydev, DAP8211R_EXT_DATA, data);
> +out:
> +	phy_unlock_mdio_bus(phydev);
> +	return ret;
> +}

[Severity: Low]
Does the kernel-doc comment for dap8211r_write_ext() state the opposite of
its locking requirement?  dap8211r_write_ext() takes the MDIO bus mutex via
phy_lock_mdio_bus(phydev), so a caller that already holds the lock will
deadlock.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113110546.173624-1-a.shimko.dev@gmail.com?part=2