Re: [PATCH net-next v20 15/15] net: airoha: add phylink support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] net: airoha: Kconfig selects hidden PCS_AIROHA symbol in
  NET_AIROHA
--

commit 5ff2dca20962cb3dbeba514686627b90b3733e68
Author: Christian Marangi <ansuelsmth@gmail.com>

net: airoha: add phylink support

This commit adds phylink support for the GDM ports in the Airoha Ethernet
driver, including PCS attachment for GDM2/3/4 and phylink-backed ethtool
link ksettings callbacks.

> diff --git a/drivers/net/ethernet/airoha/Kconfig b/drivers/net/ethernet/airoha/Kconfig
> index 1f6640a15fc94..5c54a07d2a768 100644
> --- a/drivers/net/ethernet/airoha/Kconfig
> +++ b/drivers/net/ethernet/airoha/Kconfig
> @@ -20,6 +20,8 @@ config NET_AIROHA
>  	depends on NET_DSA || !NET_DSA
>  	select NET_AIROHA_NPU
>  	select PAGE_POOL
> +	select PCS_AIROHA
> +	select PHYLINK

[Severity: Medium]
Should NET_AIROHA select FWNODE_PCS (or PCS_AIROHA_AN7581) instead of the
hidden PCS_AIROHA symbol?

PCS_AIROHA only builds pcs-airoha-common.o, while pcs-an7581.o is gated on
CONFIG_PCS_AIROHA_AN7581:

drivers/net/pcs/airoha/Makefile:
	obj-$(CONFIG_PCS_AIROHA)	:= pcs-airoha.o
	pcs-airoha-objs			:= pcs-airoha-common.o
	ifdef CONFIG_PCS_AIROHA_AN7581
	pcs-airoha-objs			+= pcs-an7581.o
	endif

When CONFIG_PCS_AIROHA_AN7581 is not enabled, selecting PCS_AIROHA builds
pcs-airoha without pcs-an7581.o, so the AN7581 PCS callbacks fall back to
inline stubs in pcs-airoha.h that return -EOPNOTSUPP during probe.
Conversely, if CONFIG_NET_AIROHA=y and CONFIG_PCS_AIROHA_AN7581=m,
selecting PCS_AIROHA forces CONFIG_PCS_AIROHA=y and builds pcs-an7581.o
into vmlinux instead of as a module.

airoha_eth.c only calls fwnode_phylink_pcs_count() and
fwnode_phylink_pcs_parse(), which are provided by CONFIG_FWNODE_PCS.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114104426.235620-1-ansuelsmth@gmail.com?part=15