All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ronald Claveau" <linux-kernel-dev@aliel.fr>
Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org
Subject: Re: [PATCH 4/7] arm64: dts: amlogic: g12: Add ranges to periphs pinctrl node
Date: Sun, 15 Nov 2026 22:37:04 +0000	[thread overview]
Message-ID: <sashiko-outbox-215882@kernel.org> (raw)
In-Reply-To: <20261115-fix-amlogic-dt-warnings-v1-4-94cbd67a32ea@aliel.fr>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: amlogic: commit subject and message mismatch with
  modified nodes
--

commit d018b851d0b76ba5915a6bfa884a1b1c4be5d03e
Author: Ronald Claveau <linux-kernel-dev@aliel.fr>

> arm64: dts: amlogic: g12: Add ranges to periphs pinctrl node
>
> Building the amlogic DTBs with W=1 reports the following warnings
> for the periphs pinctrl node:
>
>   meson-g12-common.dtsi:271.33-1554.7: Warning (unit_address_vs_reg):
>   /soc/bus@ff600000/bus@34400/pinctrl@40: node has a unit name, but no
>   reg or ranges property
>   meson-g12-common.dtsi:1768.27-2040.6: Warning (unit_address_vs_reg):
>   /soc/bus@ff800000/pinctrl@14: node has a unit name, but no reg
>   or ranges property
>   meson-g12-common.dtsi:271.33-1554.7: Warning (simple_bus_reg):
>   /soc/bus@ff600000/bus@34400/pinctrl@40: missing or empty reg/ranges
>   property
>   meson-g12-common.dtsi:1768.27-2040.6: Warning (simple_bus_reg):
>   /soc/bus@ff800000/pinctrl@14: missing or empty reg/ranges property
>   meson-g12-common.dtsi:2239.23-2279.6: Warning
>   (avoid_unnecessary_addr_size): /soc/bus@ffd00000/dsi@7000:
>   unnecessary #address-cells/#size-cells without "ranges", "dma-ranges"
>   or child "reg" or "ranges" property
>
> The pinctrl node has no reg property of its own, and its empty
> "ranges;" does not describe which address space is translated to the
> children
>
>   /soc/bus@ffd00000/dsi@7000: unnecessary #address-cells/#size-cells
>   without "ranges", "dma-ranges" or child "reg" or "ranges" property
>
> The DSI controller node has no child nodes with a reg property,
> so #address-cells and #size-cells serve no purpose. Remove them.
>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>

[Severity: Low]
This isn't a bug, but the commit subject and opening sentence only mention
the periphs_pinctrl node (pinctrl@40), whereas the patch also adds ranges to
ao_pinctrl (pinctrl@14) and removes #address-cells and #size-cells from the
unrelated mipi_dsi node (dsi@7000).

Should the mipi_dsi change be split into a separate commit (or reflected in
the subject alongside ao_pinctrl), and the duplicated dsi@7000 warning text
after the unpunctuated sentence ("...translated to the children") be cleaned
up?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-fix-amlogic-dt-warnings-v1-0-94cbd67a32ea@aliel.fr?part=4

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Ronald Claveau" <linux-kernel-dev@aliel.fr>
Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org
Subject: Re: [PATCH 4/7] arm64: dts: amlogic: g12: Add ranges to periphs pinctrl node
Date: Sun, 15 Nov 2026 22:37:04 +0000	[thread overview]
Message-ID: <sashiko-outbox-215882@kernel.org> (raw)
In-Reply-To: <20261115-fix-amlogic-dt-warnings-v1-4-94cbd67a32ea@aliel.fr>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: amlogic: commit subject and message mismatch with
  modified nodes
--

commit d018b851d0b76ba5915a6bfa884a1b1c4be5d03e
Author: Ronald Claveau <linux-kernel-dev@aliel.fr>

> arm64: dts: amlogic: g12: Add ranges to periphs pinctrl node
>
> Building the amlogic DTBs with W=1 reports the following warnings
> for the periphs pinctrl node:
>
>   meson-g12-common.dtsi:271.33-1554.7: Warning (unit_address_vs_reg):
>   /soc/bus@ff600000/bus@34400/pinctrl@40: node has a unit name, but no
>   reg or ranges property
>   meson-g12-common.dtsi:1768.27-2040.6: Warning (unit_address_vs_reg):
>   /soc/bus@ff800000/pinctrl@14: node has a unit name, but no reg
>   or ranges property
>   meson-g12-common.dtsi:271.33-1554.7: Warning (simple_bus_reg):
>   /soc/bus@ff600000/bus@34400/pinctrl@40: missing or empty reg/ranges
>   property
>   meson-g12-common.dtsi:1768.27-2040.6: Warning (simple_bus_reg):
>   /soc/bus@ff800000/pinctrl@14: missing or empty reg/ranges property
>   meson-g12-common.dtsi:2239.23-2279.6: Warning
>   (avoid_unnecessary_addr_size): /soc/bus@ffd00000/dsi@7000:
>   unnecessary #address-cells/#size-cells without "ranges", "dma-ranges"
>   or child "reg" or "ranges" property
>
> The pinctrl node has no reg property of its own, and its empty
> "ranges;" does not describe which address space is translated to the
> children
>
>   /soc/bus@ffd00000/dsi@7000: unnecessary #address-cells/#size-cells
>   without "ranges", "dma-ranges" or child "reg" or "ranges" property
>
> The DSI controller node has no child nodes with a reg property,
> so #address-cells and #size-cells serve no purpose. Remove them.
>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>

[Severity: Low]
This isn't a bug, but the commit subject and opening sentence only mention
the periphs_pinctrl node (pinctrl@40), whereas the patch also adds ranges to
ao_pinctrl (pinctrl@14) and removes #address-cells and #size-cells from the
unrelated mipi_dsi node (dsi@7000).

Should the mipi_dsi change be split into a separate commit (or reflected in
the subject alongside ao_pinctrl), and the duplicated dsi@7000 warning text
after the unpunctuated sentence ("...translated to the children") be cleaned
up?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261115-fix-amlogic-dt-warnings-v1-0-94cbd67a32ea@aliel.fr?part=4

  reply	other threads:[~2026-11-15 22:37 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 22:29 [PATCH 0/7] arm64: dts: amlogic: Fix dtc warnings with W=1 Ronald Claveau
2026-11-15 22:29 ` Ronald Claveau via B4 Relay
2026-11-15 22:29 ` Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 1/7] arm64: dts: amlogic: t7: Add ranges to periphs pinctrl node Ronald Claveau
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 2/7] arm64: dts: amlogic: a1: " Ronald Claveau
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 3/7] arm64: dts: amlogic: axg: " Ronald Claveau
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-15 22:38   ` sashiko-bot
2026-11-15 22:38     ` sashiko-bot
2026-11-15 22:29 ` [PATCH 4/7] arm64: dts: amlogic: g12: " Ronald Claveau
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-15 22:37   ` sashiko-bot [this message]
2026-11-15 22:37     ` sashiko-bot
2026-11-15 22:29 ` [PATCH 5/7] arm64: dts: amlogic: gxbb: " Ronald Claveau
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 6/7] arm64: dts: amlogic: gxl: " Ronald Claveau
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-15 22:29 ` [PATCH 7/7] arm64: dts: amlogic: s4: " Ronald Claveau
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-15 22:29   ` Ronald Claveau via B4 Relay
2026-11-16  9:55 ` [PATCH 0/7] arm64: dts: amlogic: Fix dtc warnings with W=1 Neil Armstrong
2026-11-16  9:55   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-215882@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel-dev@aliel.fr \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.