From: sashiko-bot@kernel.org
To: "Adil Hüsrev Tepe" <tadilhusrev@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: iio: proximity: add Imagis ISG5320A
Date: Mon, 16 Nov 2026 07:51:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-216474@kernel.org> (raw)
In-Reply-To: <20261116074013.355363-2-tadilhusrev@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: iio: proximity: imagis,isg5320a: style and example
issues
- [Low] dt-bindings: iio: proximity: imagis,isg5320a: OS-specific
description
--
commit e012fe4a93b96b30e3eac1a75009b8703a8aa96e
Author: Adil Hüsrev Tepe <tadilhusrev@gmail.com>
dt-bindings: iio: proximity: add Imagis ISG5320A
This commit adds a Devicetree binding schema for the Imagis ISG5320A I2C
capacitive SAR/grip proximity sensor.
> diff --git a/Documentation/devicetree/bindings/iio/proximity/imagis,isg5320a.yaml b/Documentation/devicetree/bindings/iio/proximity/imagis,isg5320a.yaml
> new file mode 100644
> index 0000000000000..b23d6bafd39e3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/proximity/imagis,isg5320a.yaml
> @@ -0,0 +1,56 @@
[ ... ]
> +description:
> + Imagis ISG5320A capacitive SAR/grip sensor (I2C), exposed as one IIO
> + proximity channel (B-channel diff = CDC16_T - BSL16_B). As fitted on the
> + Samsung Galaxy XCover5.
> +
> +properties:
> + compatible:
> + const: imagis,isg5320a
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> + description: active-low data-ready / proximity interrupt
> +
> + vdd-supply:
> + description: sensor supply
> +
> + wakeup-source: true
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
[Severity: Low]
Could the description focus on the hardware characteristics of the ISG5320A
rather than how the Linux IIO driver exposes a single channel or which
board uses it?
Also, vdd-supply can simply be "vdd-supply: true" and should be listed
under required since the sensor needs its VDD rail to operate.
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + grip@28 {
> + compatible = "imagis,isg5320a";
> + reg = <0x28>;
> + interrupt-parent = <&gpa2>;
> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> + vdd-supply = <&grip_vdd>;
> + wakeup-source;
> + };
> + };
[Severity: Low]
Does the example need a blank line between "#size-cells = <0>;" and the
child node? Without it, "scripts/dtc/dt-check-style --mode=strict" warns
on required-blank-lines.
Also, the unused <dt-bindings/gpio/gpio.h> include can be dropped, and the
node name should use the generic "proximity@28" instead of "grip@28".
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116074013.355363-1-tadilhusrev@gmail.com?part=1
next prev parent reply other threads:[~2026-11-16 7:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 7:40 [PATCH v1 0/2] iio: proximity: add Imagis ISG5320A (Samsung Galaxy XCover5) Adil Hüsrev Tepe
2026-11-16 7:40 ` [PATCH v1 1/2] dt-bindings: iio: proximity: add Imagis ISG5320A Adil Hüsrev Tepe
2026-11-16 7:51 ` sashiko-bot [this message]
2026-11-16 7:40 ` [PATCH v1 2/2] iio: proximity: add Imagis ISG5320A SAR sensor driver Adil Hüsrev Tepe
2026-11-16 7:58 ` sashiko-bot
2026-11-16 10:53 ` Andy Shevchenko
2026-11-16 10:48 ` [PATCH v1 0/2] iio: proximity: add Imagis ISG5320A (Samsung Galaxy XCover5) Andy Shevchenko
2026-11-17 10:44 ` [PATCH v2 1/2] dt-bindings: iio: proximity: add Imagis ISG5320A Adil Hüsrev Tepe
2026-11-17 10:44 ` [PATCH v2 2/2] iio: proximity: add Imagis ISG5320A SAR sensor driver Adil Hüsrev Tepe
2026-11-17 11:08 ` sashiko-bot
2026-11-17 13:56 ` Andy Shevchenko
2026-11-17 10:54 ` [PATCH v2 1/2] dt-bindings: iio: proximity: add Imagis ISG5320A sashiko-bot
2026-11-17 17:33 ` [PATCH v3 0/2] iio: proximity: add Imagis ISG5320A (Samsung Galaxy XCover5) Adil Hüsrev Tepe
2026-11-17 17:33 ` [PATCH v3 1/2] dt-bindings: iio: proximity: add Imagis ISG5320A Adil Hüsrev Tepe
2026-11-17 17:33 ` [PATCH v3 2/2] iio: proximity: add Imagis ISG5320A SAR sensor driver Adil Hüsrev Tepe
2026-11-17 17:55 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216474@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tadilhusrev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.