From: sashiko-bot@kernel.org
To: "Adil Hüsrev Tepe" <tadilhusrev@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: proximity: add Imagis ISG5320A
Date: Tue, 17 Nov 2026 10:54:14 +0000 [thread overview]
Message-ID: <sashiko-outbox-218677@kernel.org> (raw)
In-Reply-To: <20261117104414.1182364-1-tadilhusrev@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] dt-bindings: iio: proximity: duplicate int-gpios property in
imagis,isg5320a
- [Low] dt-bindings: iio: proximity: patch changelog in permanent commit
message
--
commit a0ca949bf69221deb4e3e78d116e407964e58ad3
Author: Adil Hüsrev Tepe <tadilhusrev@gmail.com>
dt-bindings: iio: proximity: add Imagis ISG5320A
This commit adds a Devicetree binding schema for the Imagis ISG5320A
I2C capacitive SAR/grip proximity sensor.
> v1 -> v2 (addressing Sashiko AI's review of v1,
> https://sashiko.dev/#/patchset/20261116074013.355363-1-tadilhusrev@gmail.com?part=1):
> - Document int-gpios: the driver optionally reads it during the reset
> sequence; it was undocumented in v1.
> - Reword the description to the chip's own characteristics instead of
> how the Linux IIO channel is exposed.
> - Simplify vdd-supply to "vdd-supply: true" (left optional: the
> XCover5's own grip sensor has no vdd-supply node at all, an
> always-on LDO not modeled in DT, which the driver's
> devm_regulator_get_enable_optional() already tolerates).
> - Rename the example node to "proximity@28", drop the unused gpio.h
> include, and add the blank line dt-check-style wants before the
> child node.
[Severity: Low]
Should this patch revision changelog be placed below the "---" separator
line rather than in the commit message body so that it is not recorded in
the permanent git history?
> diff --git a/Documentation/devicetree/bindings/iio/proximity/imagis,isg5320a.yaml b/Documentation/devicetree/bindings/iio/proximity/imagis,isg5320a.yaml
> new file mode 100644
> index 0000000000000..ccb84b29f468b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/proximity/imagis,isg5320a.yaml
> @@ -0,0 +1,62 @@
[ ... ]
> + interrupts:
> + maxItems: 1
> + description: active-low data-ready / proximity interrupt
> +
> + int-gpios:
> + maxItems: 1
> + description:
> + GPIO connected to the same INT line as the "interrupts" property. When
> + present it is polled during the reset sequence to observe the INT level,
> + as the vendor driver does; otherwise the reset falls back to fixed delays.
[Severity: Low]
Should int-gpios be dropped from the binding?
A single physical interrupt line that is only observed by the host is
already described by the required interrupts property and should not be
duplicated as both interrupts and int-gpios on the same node. Requesting
the same pin as both a GPIO input and an interrupt can also cause pinmux
or GPIO-IRQ lock conflicts on platforms where the interrupt parent is a
GPIO controller (such as Exynos pinctrl). In addition, Devicetree bindings
describe hardware rather than driver polling or reset implementation
details.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117104414.1182364-1-tadilhusrev@gmail.com?part=1
next prev parent reply other threads:[~2026-11-17 10:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 7:40 [PATCH v1 0/2] iio: proximity: add Imagis ISG5320A (Samsung Galaxy XCover5) Adil Hüsrev Tepe
2026-11-16 7:40 ` [PATCH v1 1/2] dt-bindings: iio: proximity: add Imagis ISG5320A Adil Hüsrev Tepe
2026-11-16 7:51 ` sashiko-bot
2026-11-16 7:40 ` [PATCH v1 2/2] iio: proximity: add Imagis ISG5320A SAR sensor driver Adil Hüsrev Tepe
2026-11-16 7:58 ` sashiko-bot
2026-11-16 10:53 ` Andy Shevchenko
2026-11-16 10:48 ` [PATCH v1 0/2] iio: proximity: add Imagis ISG5320A (Samsung Galaxy XCover5) Andy Shevchenko
2026-11-17 10:44 ` [PATCH v2 1/2] dt-bindings: iio: proximity: add Imagis ISG5320A Adil Hüsrev Tepe
2026-11-17 10:44 ` [PATCH v2 2/2] iio: proximity: add Imagis ISG5320A SAR sensor driver Adil Hüsrev Tepe
2026-11-17 11:08 ` sashiko-bot
2026-11-17 13:56 ` Andy Shevchenko
2026-11-17 10:54 ` sashiko-bot [this message]
2026-11-17 17:33 ` [PATCH v3 0/2] iio: proximity: add Imagis ISG5320A (Samsung Galaxy XCover5) Adil Hüsrev Tepe
2026-11-17 17:33 ` [PATCH v3 1/2] dt-bindings: iio: proximity: add Imagis ISG5320A Adil Hüsrev Tepe
2026-11-17 17:33 ` [PATCH v3 2/2] iio: proximity: add Imagis ISG5320A SAR sensor driver Adil Hüsrev Tepe
2026-11-17 17:55 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218677@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tadilhusrev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.