All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Linus Walleij" <linusw@kernel.org>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 3/3] ARM: dts: ux500: Remove DB8500 EPOD regulators
Date: Mon, 16 Nov 2026 10:31:55 +0000	[thread overview]
Message-ID: <sashiko-outbox-216743@kernel.org> (raw)
In-Reply-To: <20261116-ux500-powerdomain-dts-v1-3-e0f4459c3ab1@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ARM: dts: ux500: msp nodes violate stericsson,ux500-msp-i2s.yaml
  schema
--

commit e90c23c3e45f366c116a480287c57c3050b7236b
Author: Linus Walleij <linusw@kernel.org>

ARM: dts: ux500: Remove DB8500 EPOD regulators

This commit removes the db8500-prcmu-regulators node and drops the
associated regulator supply properties from the MSP, GPU, and MCDE nodes
in ste-dbx5x0.dtsi.

> diff --git a/arch/arm/boot/dts/st/ste-dbx5x0.dtsi b/arch/arm/boot/dts/st/ste-dbx5x0.dtsi
> index b3b3cec696561..967444e4a618a 100644
> --- a/arch/arm/boot/dts/st/ste-dbx5x0.dtsi
> +++ b/arch/arm/boot/dts/st/ste-dbx5x0.dtsi

[ ... ]

> @@ -1118,8 +1027,6 @@ msp0: msp@80123000 {
>  			#sound-dai-cells = <0>;
>  			reg = <0x80123000 0x1000>;
>  			interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> -			/* TODO: delete and replace with power-domain handling */
> -			v-ape-supply = <&db8500_vape_reg>;
>  			power-domains = <&pm_domains DOMAIN_VAPE>;

[Severity: Low]
Does dropping v-ape-supply from msp0 through msp3 break dtbs_check against
Documentation/devicetree/bindings/sound/stericsson,ux500-msp-i2s.yaml?
That schema still lists v-ape-supply under required and sets
unevaluatedProperties: false without documenting power-domains.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-ux500-powerdomain-dts-v1-0-e0f4459c3ab1@kernel.org?part=3

  reply	other threads:[~2026-11-16 10:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 10:18 [PATCH 0/3] ARM: dts: ux500: Convert EPOD consumers to power domains Linus Walleij
2026-11-16 10:18 ` [PATCH 1/3] ARM: dts: ux500: Rename power domains node Linus Walleij
2026-11-16 10:18 ` [PATCH 2/3] ARM: dts: ux500: Add power domains Linus Walleij
2026-11-16 10:55   ` sashiko-bot
2026-11-17 18:41     ` Linus Walleij
2026-11-16 10:18 ` [PATCH 3/3] ARM: dts: ux500: Remove DB8500 EPOD regulators Linus Walleij
2026-11-16 10:31   ` sashiko-bot [this message]
2026-11-17 18:42     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216743@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linusw@kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.