All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Linus Walleij" <linusw@kernel.org>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: ux500: Add power domains
Date: Mon, 16 Nov 2026 10:55:40 +0000	[thread overview]
Message-ID: <sashiko-outbox-216799@kernel.org> (raw)
In-Reply-To: <20261116-ux500-powerdomain-dts-v1-2-e0f4459c3ab1@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ARM: dts: ux500: undocumented power-domains on sram, scu, mtu,
  gpio, dma, msp
--

commit ad3830cd03ea9fc02a3f12605289fd37c7711d23
Author: Linus Walleij <linusw@kernel.org>

ARM: dts: ux500: Add power domains

This commit adds power-domains properties to the CPU and SoC peripheral
device tree nodes in ste-dbx5x0.dtsi.

> diff --git a/arch/arm/boot/dts/st/ste-dbx5x0.dtsi b/arch/arm/boot/dts/st/ste-dbx5x0.dtsi
> index 5b2b4527a4724..b3b3cec696561 100644
> --- a/arch/arm/boot/dts/st/ste-dbx5x0.dtsi
> +++ b/arch/arm/boot/dts/st/ste-dbx5x0.dtsi
[ ... ]
> @@ -154,6 +156,7 @@ sram@40020000 {
>  			reg = <0x40020000 0x40000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> +			power-domains = <&pm_domains DOMAIN_ESRAM_12>;
>  			ranges = <0 0x40020000 0x40000>;
>  		};
>  		sram@40060000 {
> @@ -162,6 +165,7 @@ sram@40060000 {
>  			reg = <0x40060000 0x40000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> +			power-domains = <&pm_domains DOMAIN_ESRAM_34>;
>  			ranges = <0 0x40060000 0x40000>;

[Severity: Low]
Do the DT binding schemas for these nodes allow the power-domains
property?

Adding power-domains to sram@40020000 and sram@40060000 (sram/sram.yaml),
as well as scu@a0410000 (arm/arm,scu.yaml), mtu@a03c6000
(timer/st,nomadik-mtu.yaml), gpio0 through gpio8
(gpio/st,nomadik-gpio.yaml), dma-controller@801C0000
(dma/stericsson,dma40.yaml), and msp0 through msp3
(sound/stericsson,ux500-msp-i2s.yaml) below, causes dtbs_check to fail
because those schemas set additionalProperties or unevaluatedProperties to
false without documenting power-domains.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-ux500-powerdomain-dts-v1-0-e0f4459c3ab1@kernel.org?part=2

  reply	other threads:[~2026-11-16 10:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 10:18 [PATCH 0/3] ARM: dts: ux500: Convert EPOD consumers to power domains Linus Walleij
2026-11-16 10:18 ` [PATCH 1/3] ARM: dts: ux500: Rename power domains node Linus Walleij
2026-11-16 10:18 ` [PATCH 2/3] ARM: dts: ux500: Add power domains Linus Walleij
2026-11-16 10:55   ` sashiko-bot [this message]
2026-11-17 18:41     ` Linus Walleij
2026-11-16 10:18 ` [PATCH 3/3] ARM: dts: ux500: Remove DB8500 EPOD regulators Linus Walleij
2026-11-16 10:31   ` sashiko-bot
2026-11-17 18:42     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216799@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linusw@kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.